----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126221/#review89070 -----------------------------------------------------------
I'm glad that you found a solution which works just in time for the release! Good work! - Martin Gräßlin On Dec. 3, 2015, 5:11 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126221/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2015, 5:11 a.m.) > > > Review request for Plasma. > > > Bugs: 355069 > https://bugs.kde.org/show_bug.cgi?id=355069 > > > Repository: plasma-workspace > > > Description > ------- > > The notifications popup positioning recently regressed > by some other changes (looks like Qt) and the popups > would fly across the screen (bug 355069). > > The proper solution is using KWin effect but given how > close the release is, this needs to be dealt with in a > different way. > > The main problem is calculating the initial popup size > because as long as the Dialog is invisible, it has an > incorrect geometry, so it needs to be positioned right > after it's being displayed. The Dialog however gets the > sizes even later, so the code now calls a slot from Dialog > that ensures the sizes are correct before the initial > placement on screen. It's not ideal but I'm out of ideas > otherwise. Plus it should be only temporary until the > KWin effect will replace it. > > > Diffs > ----- > > applets/notifications/lib/notificationsapplet.cpp aa50aef > applets/notifications/package/contents/ui/Notifications.qml 306169c > applets/notifications/plugin/notificationshelper.h cb9b335 > applets/notifications/plugin/notificationshelper.cpp 7c0dd99 > applets/notifications/lib/notificationsapplet.h dc31e1d > > Diff: https://git.reviewboard.kde.org/r/126221/diff/ > > > Testing > ------- > > I can no longer reproduce notifications flying across > the screen. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
