Re: Review Request 125555: Port KAuth return code error checking in fontinst

2015-10-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/ --- (Updated Oct. 26, 2015, 10:32 p.m.) Status -- This change has been m

Re: Review Request 125555: Port KAuth return code error checking in fontinst

2015-10-22 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/#review87256 --- Ship it! Ship It! - Martin Gräßlin On Oct. 8, 2015, 3:38 p

Re: Review Request 125555: Port KAuth return code error checking in fontinst

2015-10-22 Thread Martin Gräßlin
> On Oct. 19, 2015, 12:40 p.m., Martin Gräßlin wrote: > > kcms/kfontinst/dbus/FontInst.cpp, line 957 > > > > > > that's an async call, isn't it? So somehow I doubt it will work that > > way. > > David Edmundson

Re: Review Request 125555: Port KAuth return code error checking in fontinst

2015-10-21 Thread David Edmundson
> On Oct. 19, 2015, 10:40 a.m., Martin Gräßlin wrote: > > kcms/kfontinst/dbus/FontInst.cpp, line 957 > > > > > > that's an async call, isn't it? So somehow I doubt it will work that > > way. > > David Edmundson

Re: Review Request 125555: Port KAuth return code error checking in fontinst

2015-10-19 Thread Martin Gräßlin
> On Oct. 19, 2015, 12:40 p.m., Martin Gräßlin wrote: > > kcms/kfontinst/dbus/FontInst.cpp, line 957 > > > > > > that's an async call, isn't it? So somehow I doubt it will work that > > way. > > David Edmundson

Re: Review Request 125555: Port KAuth return code error checking in fontinst

2015-10-19 Thread David Edmundson
> On Oct. 19, 2015, 10:40 a.m., Martin Gräßlin wrote: > > kcms/kfontinst/dbus/FontInst.cpp, line 957 > > > > > > that's an async call, isn't it? So somehow I doubt it will work that > > way. no, this is KJob::e

Re: Review Request 125555: Port KAuth return code error checking in fontinst

2015-10-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/#review87060 --- kcms/kfontinst/dbus/FontInst.cpp (line 957)

Re: Review Request 125555: Port KAuth return code error checking in fontinst

2015-10-09 Thread David Edmundson
> On Oct. 9, 2015, 11:56 p.m., Hrvoje Senjan wrote: > > kcms/kfontinst/dbus/FontInst.cpp, line 958 > > > > > > Shouldn't this be if (!j->exec()) { ? Same thing really final line of KJob::exec() is return (

Re: Review Request 125555: Port KAuth return code error checking in fontinst

2015-10-09 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/#review86603 --- kcms/kfontinst/dbus/FontInst.cpp (line 958)

Re: Review Request 125555: Port KAuth return code error checking in fontinst

2015-10-08 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/ --- (Updated Oct. 8, 2015, 1:38 p.m.) Review request for Plasma. Changes --