> On Oct. 9, 2015, 11:56 p.m., Hrvoje Senjan wrote:
> > kcms/kfontinst/dbus/FontInst.cpp, line 958
> > <https://git.reviewboard.kde.org/r/125555/diff/1/?file=410313#file410313line958>
> >
> > Shouldn't this be if (!j->exec()) { ?
Same thing really
final line of KJob::exec() is
return (d->error == 0);
Can change if you think it's clearer
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125555/#review86603
-----------------------------------------------------------
On Oct. 8, 2015, 1:38 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125555/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 1:38 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Someone whilst porting had simply commented it out
> This causes the install dialog to freeze if there's a problem.
>
> CCBUG: 344473
> CCBUG: 300951
> CCBUG: 345234
>
>
> Diffs
> -----
>
> kcms/kfontinst/dbus/FontInst.cpp 42413c1a05717f416681ef32317b8914c2ba35ec
>
> Diff: https://git.reviewboard.kde.org/r/125555/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
