Re: Review Request 124463: Disable devicePixelRatio in PlasmaShell

2015-07-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124463/ --- (Updated July 26, 2015, 11:02 a.m.) Status -- This change has been m

Re: Review Request 124463: Disable devicePixelRatio in PlasmaShell

2015-07-25 Thread Mark Gaiser
On jul 25, 2015, 7:38 p.m., David Edmundson wrote: > > Quote: > > -- It's also not a /huge/ deal as we do our own thing anyway, so the > > -- experience is better to just turn off this scaling. > > > > I find that excuse somewhat weak. Sure, Qt's way of scaling is biting now, > > but that's _be

Re: Review Request 124463: Disable devicePixelRatio in PlasmaShell

2015-07-25 Thread Martin Klapetek
> On July 25, 2015, 10:24 p.m., Martin Klapetek wrote: > > +1, I've been running this patch since forever as well on my hidpi laptop, > > there are no issues without it as far as I can say. Err, meant just +1, not ship it but oh well. - Martin ---

Re: Review Request 124463: Disable devicePixelRatio in PlasmaShell

2015-07-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124463/#review82961 --- Ship it! +1, I've been running this patch since forever as we

Re: Review Request 124463: Disable devicePixelRatio in PlasmaShell

2015-07-25 Thread Martin Klapetek
On July 25, 2015, 9:38 p.m., David Edmundson wrote: > > Quote: > > -- It's also not a /huge/ deal as we do our own thing anyway, so the > > -- experience is better to just turn off this scaling. > > > > I find that excuse somewhat weak. Sure, Qt's way of scaling is biting now, > > but that's _b

Re: Review Request 124463: Disable devicePixelRatio in PlasmaShell

2015-07-25 Thread David Edmundson
> On July 25, 2015, 7:38 p.m., Mark Gaiser wrote: > > shell/main.cpp, line 42 > > > > > > You should put heavy documentation around this line to explain why you > > do that. Even if this hack is short lived and r

Re: Review Request 124463: Disable devicePixelRatio in PlasmaShell

2015-07-25 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124463/#review82958 --- shell/main.cpp (line 42)