> On July 25, 2015, 7:38 p.m., Mark Gaiser wrote: > > shell/main.cpp, line 42 > > <https://git.reviewboard.kde.org/r/124463/diff/1/?file=387506#file387506line42> > > > > You should put heavy documentation around this line to explain why you > > do that. Even if this hack is short lived and reverted in a few months. > > > > Basically just paste the description of this rr above that line.
will do On July 25, 2015, 7:38 p.m., David Edmundson wrote: > > Quote: > > -- It's also not a /huge/ deal as we do our own thing anyway, so the > > -- experience is better to just turn off this scaling. > > > > I find that excuse somewhat weak. Sure, Qt's way of scaling is biting now, > > but that's _becasue_ plasma had to make it's own way of scaling. Sure, i > > know the reasons why it was done and it was the best choice back then, but > > from day 1 it was known to become an issue if Qt was also going to support > > scaling. Which it obviously did since it has to keep up with modern day > > standards. > > > > Plasma now is in the weird position where it needs to either adapt it's > > scaling to not conflict with Qt or throw all the custom scaling code away > > and start using the Qt way. Neither is easy imho. I would say "we would just turn it off" but we have a few places where we draw not using plasma components; but via QWidgets such as Menus, Dialogs, and some of the QQC stuff; and that's where we have problems. In later Qt we should have a way to say "I'll do my own scaling kthnxbye" *per window*, which I think is the ultimate long term solution. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124463/#review82958 ----------------------------------------------------------- On July 25, 2015, 4:46 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124463/ > ----------------------------------------------------------- > > (Updated July 25, 2015, 4:46 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Devive pixel ratio has some problems in plasmashell currently. > > In particular: > - dialog continually expands (347951) > - Text element text is screwed (QTBUG-42606) > - Panel struts (350614) > > It's also not a /huge/ deal as we do our own thing anyway, so the > experience is better to just turn off this scaling. > > I've had this patch in my local code since forever. > > We should revert this > when all 3 are fixed. > > I'm not willing to currently spend my effort whilst we still have that Qt bug > blocking this; but I want to enable the setting for apps in 5.4 > > CCBUG: 347951 > > > Diffs > ----- > > shell/main.cpp 5c5a5cabb5cac8b3fca063185a82582b187e434e > > Diff: https://git.reviewboard.kde.org/r/124463/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
