Re: Review Request 118613: Prevent crash when requesting icon with negative size

2014-06-08 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118613/ --- (Updated June 8, 2014, 11:42 a.m.) Status -- This change has been ma

Re: Review Request 118613: Prevent crash when requesting icon with negative size

2014-06-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118613/#review59553 --- This review has been submitted with commit 86c1f46eaa2ffe3849

Re: Review Request 118613: Prevent crash when requesting icon with negative size

2014-06-08 Thread David Edmundson
> On June 8, 2014, 9:52 a.m., Martin Klapetek wrote: > > src/declarativeimports/core/iconitem.cpp, lines 295-296 > > > > > > Unrelated general question - why is there m_iconPixmap and m_pixmapIcon > > and what's

Re: Review Request 118613: Prevent crash when requesting icon with negative size

2014-06-08 Thread Martin Klapetek
> On June 8, 2014, 11:52 a.m., Martin Klapetek wrote: > > src/declarativeimports/core/iconitem.cpp, lines 295-296 > > > > > > Unrelated general question - why is there m_iconPixmap and m_pixmapIcon > > and what'

Re: Review Request 118613: Prevent crash when requesting icon with negative size

2014-06-08 Thread David Edmundson
> On June 8, 2014, 9:52 a.m., Martin Klapetek wrote: > > src/declarativeimports/core/iconitem.cpp, lines 295-296 > > > > > > Unrelated general question - why is there m_iconPixmap and m_pixmapIcon > > and what's

Re: Review Request 118613: Prevent crash when requesting icon with negative size

2014-06-08 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118613/#review59545 --- src/declarativeimports/core/iconitem.cpp

Re: Review Request 118613: Prevent crash when requesting icon with negative size

2014-06-08 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118613/#review59544 --- Ship it! Ship It! - David Edmundson On June 8, 2014, 4:45

Re: Review Request 118613: Prevent crash when requesting icon with negative size

2014-06-07 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118613/ --- (Updated June 8, 2014, 10:15 a.m.) Review request for Plasma. Bugs: 335