----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118613/#review59545 -----------------------------------------------------------
src/declarativeimports/core/iconitem.cpp <https://git.reviewboard.kde.org/r/118613/#comment41498> Unrelated general question - why is there m_iconPixmap and m_pixmapIcon and what's the difference? - Martin Klapetek On June 8, 2014, 6:45 a.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118613/ > ----------------------------------------------------------- > > (Updated June 8, 2014, 6:45 a.m.) > > > Review request for Plasma. > > > Bugs: 335939 > http://bugs.kde.org/show_bug.cgi?id=335939 > > > Repository: plasma-framework > > > Description > ------- > > Prevent crash when requesting icon with negative size. > > > Diffs > ----- > > src/declarativeimports/core/iconitem.cpp 9e0cb36 > > Diff: https://git.reviewboard.kde.org/r/118613/diff/ > > > Testing > ------- > > tried to resize some icons.. no longer crashes > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
