Re: Review Request 114380: Port share dataengine

2013-12-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114380/#review45471 --- This review has been submitted with commit 5edfe04af85fb3302bf

Re: Review Request 114380: Port share dataengine

2013-12-10 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114380/ --- (Updated Dec. 10, 2013, 3:57 p.m.) Status -- This change has been mar

Re: Review Request 114380: Port share dataengine

2013-12-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114380/#review45469 --- Ship it! Ship It! - Sebastian Kügler On Dec. 10, 2013, 3:17

Re: Review Request 114380: Port share dataengine

2013-12-10 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114380/ --- (Updated Dec. 10, 2013, 8:47 p.m.) Review request for Plasma and Sebastian

Re: Review Request 114380: Port share dataengine

2013-12-10 Thread Bhushan Shah
> On Dec. 10, 2013, 8:30 p.m., Sebastian Kügler wrote: > > plasma/generic/dataengines/share/shareengine.cpp, line 118 > > > > > > I don't see where this json file is generated. Is it at all? data/CMakeLists.txt

Re: Review Request 114380: Port share dataengine

2013-12-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114380/#review45461 --- plasma/generic/dataengines/share/share_package.cpp