Re: Review Request 114378: Add a hideOnWindowDeactivate property to PlasmaCore.Dialog

2013-12-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114378/#review45529 --- This review has been submitted with commit 86d030eface9b88369d

Re: Review Request 114378: Add a hideOnWindowDeactivate property to PlasmaCore.Dialog

2013-12-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114378/ --- (Updated Dec. 11, 2013, 10:18 a.m.) Status -- This change has been ma

Re: Review Request 114378: Add a hideOnWindowDeactivate property to PlasmaCore.Dialog

2013-12-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114378/#review45527 --- Ship it! Ship It! - Sebastian Kügler On Dec. 11, 2013, 7:06

Re: Review Request 114378: Add a hideOnWindowDeactivate property to PlasmaCore.Dialog

2013-12-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114378/ --- (Updated Dec. 11, 2013, 8:06 a.m.) Review request for Plasma and Sebastian

Re: Review Request 114378: Add a hideOnWindowDeactivate property to PlasmaCore.Dialog

2013-12-10 Thread Martin Gräßlin
> On Dec. 10, 2013, 3:40 p.m., Sebastian Kügler wrote: > > src/declarativeimports/core/dialog.h, line 93 > > > > > > READ hideOnWindowDeactivate? > > > > Or is there a reason to use is*** here, such as an

Re: Review Request 114378: Add a hideOnWindowDeactivate property to PlasmaCore.Dialog

2013-12-10 Thread Sebastian Kügler
> On Dec. 10, 2013, 2:40 p.m., Sebastian Kügler wrote: > > src/declarativeimports/core/dialog.h, line 93 > > > > > > READ hideOnWindowDeactivate? > > > > Or is there a reason to use is*** here, such as an

Re: Review Request 114378: Add a hideOnWindowDeactivate property to PlasmaCore.Dialog

2013-12-10 Thread Martin Gräßlin
> On Dec. 10, 2013, 3:40 p.m., Sebastian Kügler wrote: > > So you mean that whether or not to set it depends on KWin's focuspolicy and > > should be taken into account in CompactApplet.qml? no, it's just a very easy way to see when it should not be hidden. E.g. if you need to have the mouse in

Re: Review Request 114378: Add a hideOnWindowDeactivate property to PlasmaCore.Dialog

2013-12-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114378/#review45459 --- src/declarativeimports/core/dialog.h

Re: Review Request 114378: Add a hideOnWindowDeactivate property to PlasmaCore.Dialog

2013-12-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114378/#review45460 --- So you mean that whether or not to set it depends on KWin's foc