Re: Review Request 114295: Fix textfield/lineedit hover frame with QtQuickControls

2013-12-08 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114295/ --- (Updated Dec. 8, 2013, 3:05 p.m.) Status -- This change has been mark

Re: Review Request 114295: Fix textfield/lineedit hover frame with QtQuickControls

2013-12-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114295/#review45352 --- This review has been submitted with commit 860401fb39398587757

Re: Review Request 114295: Fix textfield/lineedit hover frame with QtQuickControls

2013-12-08 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114295/#review45340 --- Ship it! Ship It! - Hugo Pereira Da Costa On Dec. 6, 2013,

Re: Review Request 114295: Fix textfield/lineedit hover frame with QtQuickControls

2013-12-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114295/ --- (Updated Dec. 6, 2013, 9:28 a.m.) Review request for Plasma and Hugo Perei

Re: Review Request 114295: Fix textfield/lineedit hover frame with QtQuickControls

2013-12-06 Thread Martin Klapetek
> On Dec. 6, 2013, 9:17 a.m., Hugo Pereira Da Costa wrote: > > kstyles/oxygen/oxygenstyle.cpp, line 2415 > > > > > > I think the test can be made more efficient: > > if a widget is set, whether it is hovered

Re: Review Request 114295: Fix textfield/lineedit hover frame with QtQuickControls

2013-12-06 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114295/#review45250 --- kstyles/oxygen/oxygenstyle.cpp

Re: Review Request 114295: Fix textfield/lineedit hover frame with QtQuickControls

2013-12-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114295/#review45086 --- Ship it! Nice, can you fix TextArea too whilst you're at it?