----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114295/#review45250 -----------------------------------------------------------
kstyles/oxygen/oxygenstyle.cpp <http://git.reviewboard.kde.org/r/114295/#comment32328> I think the test can be made more efficient: if a widget is set, whether it is hovered or not, then the QtQuick tests should not be done at all, which should spare some time. This can likely be done by "const bool isQtQuickControl = (!widget) && option && ...; can you confirm ? - Hugo Pereira Da Costa On Dec. 4, 2013, 11:24 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114295/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2013, 11:24 a.m.) > > > Review request for Plasma and Hugo Pereira Da Costa. > > > Repository: kde-workspace > > > Description > ------- > > The QtQuickControls' textfield does not have a hover frame as it fails the > input widget test (as widget == 0 when called from QQC), so the test is > expanded to check if it's QQC textfield ("edit"). > > > Diffs > ----- > > kstyles/oxygen/oxygenstyle.cpp 50c217f > > Diff: http://git.reviewboard.kde.org/r/114295/diff/ > > > Testing > ------- > > QQC textfield gets nice hover frame when mouse hovers over it. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
