Re: Review Request 113659: system-monitor plasmoid: respect settings from js code

2013-11-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113659/#review43769 --- This review has been submitted with commit 0c1a1f5eaacab9347d7

Re: Review Request 113659: system-monitor plasmoid: respect settings from js code

2013-11-15 Thread Sergei Lopatin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113659/ --- (Updated Nov. 15, 2013, 8:26 p.m.) Status -- This change has been mar

Re: Review Request 113659: system-monitor plasmoid: respect settings from js code

2013-11-05 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113659/#review43126 --- Ship it! I still think it'd be preferrable to rewrite System M

Re: Review Request 113659: system-monitor plasmoid: respect settings from js code

2013-11-05 Thread Sergei Lopatin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113659/ --- (Updated Nov. 5, 2013, 10:34 p.m.) Review request for Plasma and Eike Hein

Re: Review Request 113659: system-monitor plasmoid: respect settings from js code

2013-11-05 Thread Sergei Lopatin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113659/ --- (Updated Nov. 5, 2013, 9:52 p.m.) Review request for Plasma and Eike Hein.

Re: Review Request 113659: system-monitor plasmoid: respect settings from js code

2013-11-05 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113659/#review43124 --- Avoiding recreating applets unnecessary is a good improvement,

Re: Review Request 113659: system-monitor plasmoid: respect settings from js code

2013-11-05 Thread Sergei Lopatin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113659/ --- (Updated Nov. 5, 2013, 8:58 p.m.) Review request for Plasma and Eike Hein.

Re: Review Request 113659: system-monitor plasmoid: respect settings from js code

2013-11-05 Thread Eike Hein
> On Nov. 5, 2013, 7:39 p.m., Eike Hein wrote: > > This is a promising first start. Indeed, the System Monitor applet didn't > > implement configChanged(), causing scripting its configuration not to work, > > as we talked about on IRC. > > > > However, the implementation in the proposed patch

Re: Review Request 113659: system-monitor plasmoid: respect settings from js code

2013-11-05 Thread Sergei Lopatin
> On Nov. 5, 2013, 7:39 p.m., Eike Hein wrote: > > This is a promising first start. Indeed, the System Monitor applet didn't > > implement configChanged(), causing scripting its configuration not to work, > > as we talked about on IRC. > > > > However, the implementation in the proposed patch

Re: Review Request 113659: system-monitor plasmoid: respect settings from js code

2013-11-05 Thread Sergei Lopatin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113659/ --- (Updated Nov. 5, 2013, 7:44 p.m.) Review request for Plasma and Eike Hein.