Re: Review Request: Config cleanup on removeActivity

2012-09-01 Thread makis marimpis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106097/ --- (Updated Sept. 1, 2012, 3:44 p.m.) Review request for KDE Runtime and Plas

Re: Review Request: Config cleanup on removeActivity

2012-08-27 Thread Ivan Čukić
> On Aug. 27, 2012, 12:42 a.m., Lamarque Vieira Souza wrote: > > Ship It! > > Ivan Čukić wrote: > Which branch is this, since it is not master as specified? (in master, VD switcher is moved into a separate plugin) - Ivan --- This i

Re: Review Request: Config cleanup on removeActivity

2012-08-26 Thread Ivan Čukić
> On Aug. 27, 2012, 12:42 a.m., Lamarque Vieira Souza wrote: > > Ship It! Which branch is this, since it is not master as specified? - Ivan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Re: Review Request: Config cleanup on removeActivity

2012-08-26 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106097/#review18065 --- Ship it! Ship It! - Lamarque Vieira Souza On Aug. 20, 2012,

Re: Review Request: config

2009-05-03 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/639/ --- (Updated 2009-05-03 12:29:46.686527) Review request for Plasma. Changes ---

Re: Review Request: config

2009-05-01 Thread Chani
> The code is correct and will work that way. But we should try to get > everyone used to do: > > KAction *configAction = actions->addAction("configure"); > configAction->setIcon(KIcon("configure")); > configAction->setText("Widget Settings")) > configAction->setShortcut(KShortcut(

Re: Review Request: config

2009-05-01 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/639/ --- (Updated 2009-05-01 20:28:58.289288) Review request for Plasma. Changes ---

Re: Review Request: config

2009-05-01 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/639/ --- (Updated 2009-05-01 19:49:49.223570) Review request for Plasma. Changes ---

Re: Review Request: config

2009-05-01 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/639/ --- (Updated 2009-05-01 12:50:52.542081) Review request for Plasma. Changes ---

Re: Review Request: config

2009-04-30 Thread Chani
> On 2009-04-30 18:56:59, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/corona.h, line 303 > > > > > > what is the use case for this outside of libplasma? i get the feeling > > that this could be kept entirely internal?

Re: Review Request: config

2009-04-30 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/639/#review1014 --- /trunk/KDE/kdelibs/plasma/containment.h

Re: Review Request: config

2009-04-30 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/639/#review1012 --- /trunk/KDE/kdelibs/plasma/applet.h

Re: Review Request: config

2009-04-30 Thread Michael Jansen
Hi I can't say anything on the plasma side of the patch. But some word regarding Actions/ActionCollections. KAction *configAction = new KAction(i18n("Widget Settings"), actions); configAction->setIcon(KIcon("configure")); configAction->setShortcut(KShortcut("alt+d, s")); actions-

Re: Review Request: config

2009-04-29 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/639/ --- (Updated 2009-04-29 23:58:24.808392) Review request for Plasma. Changes ---