----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/639/#review1014 -----------------------------------------------------------
/trunk/KDE/kdelibs/plasma/containment.h <http://reviewboard.kde.org/r/639/#comment698> but corona has to access it... uhm... I guess I'd have to #include the private header in corona.cpp? I'll go do that then... /trunk/KDE/kdelibs/plasma/corona.h <http://reviewboard.kde.org/r/639/#comment697> well, I was thinking other shells might have their own shortcuts, I'm not sure. er... addShortcuts itself, I'm not sure *how* that would go in plasma-desktop. nothing in plasma-desktop has access to corona's privates. maybe I misunderstood something... /trunk/KDE/kdelibs/plasma/corona.cpp <http://reviewboard.kde.org/r/639/#comment695> not two of the same. one of applet stuff and one of containment stuff. line 107 changes the second collection. /trunk/KDE/kdelibs/plasma/corona.cpp <http://reviewboard.kde.org/r/639/#comment696> yeah, I haven't solved that yet. I want to dive into kshortcutsdialog.cpp and see what that configure() function does and if it's safe to just show() the dialog n'stuff - Chani On 2009-04-29 23:58:24, Chani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/639/ > ----------------------------------------------------------- > > (Updated 2009-04-29 23:58:24) > > > Review request for Plasma. > > > Summary > ------- > > -it's still modal > -needs testing without my local patch that fixes a qt shortcut bug > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/applet.h 960161 > /trunk/KDE/kdelibs/plasma/applet.cpp 960161 > /trunk/KDE/kdelibs/plasma/containment.h 960161 > /trunk/KDE/kdelibs/plasma/containment.cpp 960161 > /trunk/KDE/kdelibs/plasma/corona.h 960161 > /trunk/KDE/kdelibs/plasma/corona.cpp 960161 > /trunk/KDE/kdelibs/plasma/private/applet_p.h 960161 > /trunk/KDE/kdelibs/plasma/private/containment_p.h 960161 > > Diff: http://reviewboard.kde.org/r/639/diff > > > Testing > ------- > > > Thanks, > > Chani > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
