Re: Review Request: Plasmate:migrate timeline.cpp from Q classes to K classes

2011-08-23 Thread Sebastian Kügler
On Thursday, July 21, 2011 17:44:40 Giorgos Tsiapaliwkas wrote: > the patch migrates the timeline.cpp from the Q classes to K classes. > Also adds a KMessageBox::information in the newsavepoint(),in order to > inform the user that he can't create a new save point without any changes > being made >

Re: Review Request: Plasmate:migrate timeline.cpp from Q classes to K classes

2011-08-19 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102027/#review5827 --- Ship it! - Aaron J. On Aug. 18, 2011, 6:09 p.m., Giorgos Tsia

Re: Review Request: Plasmate:migrate timeline.cpp from Q classes to K classes

2011-08-18 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102027/ --- (Updated Aug. 18, 2011, 6:09 p.m.) Review request for Plasma. Changes --

Re: Review Request: Plasmate:migrate timeline.cpp from Q classes to K classes

2011-08-16 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102027/#review5758 --- savesystem/timeline.cpp

Re: Review Request: Plasmate:migrate timeline.cpp from Q classes to K classes

2011-08-16 Thread Giorgos Tsiapaliwkas
> On July 31, 2011, 8:20 a.m., Aaron J. Seigo wrote: > > savesystem/timeline.cpp, lines 236-256 > > > > > > again, there is no benefit at all to these changes here. it even makes > > it more ambiguous who owns the

Re: Review Request: Plasmate:migrate timeline.cpp from Q classes to K classes

2011-08-06 Thread Giorgos Tsiapaliwkas
> On July 31, 2011, 8:20 a.m., Aaron J. Seigo wrote: > > the dialog box changes look good. the action changes don't. please commit > > the dialog changes ... You mean the MessabeBoxs,correct? > On July 31, 2011, 8:20 a.m., Aaron J. Seigo wrote: > > savesystem/timeline.cpp, lines 236-256 > > <

Re: Review Request: Plasmate:migrate timeline.cpp from Q classes to K classes

2011-08-02 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102027/#review5251 --- the dialog box changes look good. the action changes don't. plea

Re: Review Request: Plasmate:migrate timeline.cpp from Q classes to K classes

2011-07-24 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102027/ --- (Updated July 24, 2011, 8:51 p.m.) Review request for Plasma. Changes --

Re: Review Request: Plasmate:migrate timeline.cpp from Q classes to K classes

2011-07-22 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102027/#review4957 --- savesystem/timeline.cpp