----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102027/#review5251 -----------------------------------------------------------
the dialog box changes look good. the action changes don't. please commit the dialog changes ... savesystem/timeline.cpp <http://git.reviewboard.kde.org/r/102027/#comment4749> again, there is no benefit at all to these changes here. it even makes it more ambiguous who owns the actions and introduces memory management problems. savesystem/timeline.cpp <http://git.reviewboard.kde.org/r/102027/#comment4750> needs ws around the != savesystem/timeline.cpp <http://git.reviewboard.kde.org/r/102027/#comment4751> ws missing here too savesystem/timeline.cpp <http://git.reviewboard.kde.org/r/102027/#comment4752> why? savesystem/timeline.cpp <http://git.reviewboard.kde.org/r/102027/#comment4753> why? savesystem/timeline.cpp <http://git.reviewboard.kde.org/r/102027/#comment4754> why? savesystem/timeline.cpp <http://git.reviewboard.kde.org/r/102027/#comment4755> why? savesystem/timeline.cpp <http://git.reviewboard.kde.org/r/102027/#comment4756> why? - Aaron J. On July 24, 2011, 8:51 p.m., Giorgos Tsiapaliwkas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102027/ > ----------------------------------------------------------- > > (Updated July 24, 2011, 8:51 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > hello, > > the patch migrates the timeline.cpp from the Q classes to K classes. > Also adds a KMessageBox::information in the newsavepoint(),in order to inform > the user that he can't create a new save point without any changes being made > > > Diffs > ----- > > savesystem/timeline.cpp 2ed3ac2 > > Diff: http://git.reviewboard.kde.org/r/102027/diff > > > Testing > ------- > > no issues. > > > Thanks, > > Giorgos > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
