Re: Review Request: Patch to use the data engine for status notifier items

2010-03-18 Thread Matthieu Gallien
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3265/ --- (Updated 2010-03-18 22:44:19.497406) Review request for Plasma. Changes --

Re: Review Request: Patch to use the data engine for status notifier items

2010-03-17 Thread Matthieu Gallien
> On 2010-03-17 12:13:33, Marco Martin wrote: > > what is the status of this thing? > > is the current one meant to be the final or still needs something? Hello, It is not final. It is buggy. The icons are not showing up for item like KMix. It is showing up for nepomuk only after Nepomuk starts

Re: Review Request: Patch to use the data engine for status notifier items

2010-03-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3265/#review4533 --- what is the status of this thing? is the current one meant to be the f

Re: Review Request: Patch to use the data engine for status notifier items

2010-03-14 Thread Marco Martin
On Sun, Mar 14, 2010 at 6:45 PM, Matthieu Gallien wrote: > > >> On 2010-03-12 12:04:16, Marco Martin wrote: >> > as i said on the other patch even if is not perfect it should go in asap >> > (with asap being waiting for the Aurelien patch to be committed) otherwise >> > the patch becomes really

Re: Review Request: Patch to use the data engine for status notifier items

2010-03-14 Thread Matthieu Gallien
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3265/ --- (Updated 2010-03-14 17:58:45.678252) Review request for Plasma. Changes --

Re: Review Request: Patch to use the data engine for status notifier items

2010-03-14 Thread Matthieu Gallien
> On 2010-03-12 12:04:16, Marco Martin wrote: > > as i said on the other patch even if is not perfect it should go in asap > > (with asap being waiting for the Aurelien patch to be committed) otherwise > > the patch becomes really too big. > > Just by quicly reading at the èatch i can't tell: c

Re: Review Request: Patch to use the data engine for status notifier items

2010-03-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3265/#review4484 --- Ship it! as i said on the other patch even if is not perfect it shoul