On Sun, Mar 14, 2010 at 6:45 PM, Matthieu Gallien <matthieu_gall...@yahoo.fr> wrote: > > >> On 2010-03-12 12:04:16, Marco Martin wrote: >> > as i said on the other patch even if is not perfect it should go in asap >> > (with asap being waiting for the Aurelien patch to be committed) otherwise >> > the patch becomes really too big. >> > Just by quicly reading at the èatch i can't tell: can you quantify exactly >> > what is still missing? > > The existing part in this patch was the use of the new source signal to > create new item. It was not using the data and service from the data engine. > It is now done and I will update the review with my last code. > Now, I have a problem with icon not showing up. I will investigate. > > >> On 2010-03-12 12:04:16, Marco Martin wrote: >> > /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtrayprotocol.cpp, >> > line 35 >> > <http://reviewboard.kde.org/r/3265/diff/1/?file=20657#file20657line35> >> > >> > my concern about using dataengines this way is that is not possible to >> > use them in remote applets, >> > but is a limitation of the remote applets machinery i guess > > Would you like that I try after that a patch to use the data engine from the > applet ? It means modifying the Protocol class to always take a pointer to > the applet.
wouldn't work so well, because a protocol belongs to the Manager, that is static and shared between all systray applets, if more than one, so for now it would unfortunately be the only way. _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
