Re: Review Request: Keyboard navigation for calendar applet

> On Feb. 23, 2011, 8:02 p.m., Marco Martin wrote: > > libs/plasmaclock/calendar.cpp, line 212 > > > > > > those ifs can be replaced by a switch, since it's just an enum replace by a switch! > On Feb. 23, 2011, 8:0

Re: Review Request: Keyboard navigation for calendar applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100718/#review1613 --- Ship it! almost perfect, there is still a little thing, but as

Re: Review Request: Keyboard navigation for calendar applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100718/ --- (Updated Feb. 23, 2011, 7:27 p.m.) Review request for Plasma. Changes --

Re: Review Request: Keyboard navigation for calendar applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100718/ --- (Updated Feb. 23, 2011, 8:24 a.m.) Review request for Plasma. Changes --

Re: Review Request: Keyboard navigation for calendar applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100718/#review1601 --- Just wondering if we want to have navigation for day selection i

Re: Review Request: Keyboard navigation for calendar applet

> On Feb. 22, 2011, 5:48 p.m., Marco Martin wrote: > > libs/plasmaclock/calendar.cpp, line 198 > > > > > > shouldn't grab the keyboard, but just accept focus and work only when > > focused it seems that focusInEvent

Re: Review Request: Keyboard navigation for calendar applet

> On Feb. 22, 2011, 5:45 p.m., Marco Martin wrote: > > libs/plasmaclock/calendar.cpp, line 215 > > > > > > maybe should the Home key instead of return? Ok! I changed it to the Home key :) - Farhad ---

Re: Review Request: Keyboard navigation for calendar applet

> On Feb. 22, 2011, 5:44 p.m., Farhad Hedayati Fard wrote: > > I found a bug here :P it steals key events from all other applets too... yeah, i didn't notice grabKeyboard() at first: it shouldn't do that. it should accept focus and input when explicitly activated - Marco

Re: Review Request: Keyboard navigation for calendar applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100718/#review1590 --- libs/plasmaclock/calendar.cpp

Re: Review Request: Keyboard navigation for calendar applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100718/#review1588 --- Ship it! to me is fine, only thing i'm not sure about is the us

Re: Review Request: Keyboard navigation for calendar applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100718/#review1587 --- I found a bug here :P it steals key events from all other applet

Re: Review Request: Keyboard navigation for calendar applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100718/#review1589 --- I found a bug here :P it steals key events from all other applet