----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100718/#review1613 -----------------------------------------------------------
Ship it! almost perfect, there is still a little thing, but as soon as you fixed them go for it ;) libs/plasmaclock/calendar.cpp <http://git.reviewboard.kde.org/r/100718/#comment1377> those ifs can be replaced by a switch, since it's just an enum libs/plasmaclock/calendar.cpp <http://git.reviewboard.kde.org/r/100718/#comment1378> if isn't used, remove it alltogether - Marco On Feb. 23, 2011, 7:27 p.m., Farhad Hedayati Fard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100718/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2011, 7:27 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > Added some keyboard shortcuts through "keyPressEvent"s > Key_Right -> next month > Key_Left -> previous month > Key_Return and Key_Enter -> today > Key_PageUp -> next year > Key_PageDown -> previous year > > > This addresses bug https://bugs.kde.org/show_bug.cgi?id=249866. > > http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=249866 > > > Diffs > ----- > > libs/plasmaclock/calendar.h f0f1c09 > libs/plasmaclock/calendar.cpp 57eecd6 > libs/plasmaclock/clockapplet.h b75f286 > libs/plasmaclock/clockapplet.cpp e81d549 > plasma/generic/applets/calendar/calendar.h 94cbe93 > plasma/generic/applets/calendar/calendar.cpp c83b9ee > > Diff: http://git.reviewboard.kde.org/r/100718/diff > > > Testing > ------- > > works fine here! > > > Thanks, > > Farhad > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
