Re: Review Request: Keep placeholder text visible when empty and focused

2013-01-07 Thread Aaron J. Seigo
> On Dec. 13, 2012, 4:32 p.m., Aaron J. Seigo wrote: > > as this is indeed a rather widely shifting style (far beyond KDE), as long > > as it is consistent with kdelibs and Qt i'm ok with this. and consistency > > is the hard bit. yes, there is 107678 for kdelibs (which is half the > > battle)

Re: Review Request: Keep placeholder text visible when empty and focused

2012-12-14 Thread Aurélien Gâteau
> On Dec. 13, 2012, 4:32 p.m., Aaron J. Seigo wrote: > > as this is indeed a rather widely shifting style (far beyond KDE), as long > > as it is consistent with kdelibs and Qt i'm ok with this. and consistency > > is the hard bit. yes, there is 107678 for kdelibs (which is half the > > battle)

Re: Review Request: Keep placeholder text visible when empty and focused

2012-12-13 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107600/#review23416 --- as this is indeed a rather widely shifting style (far beyond KD

Re: Review Request: Keep placeholder text visible when empty and focused

2012-12-13 Thread Laszlo Papp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107600/#review23365 --- There was a similar, but discarded patch for this: https://git

Re: Review Request: Keep placeholder text visible when empty and focused

2012-12-12 Thread Sebastian Gottfried
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107600/#review23362 --- +1 from me, I've filed a similar review request for it (https:

Re: Review Request: Keep placeholder text visible when empty and focused

2012-12-12 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107600/ --- (Updated Dec. 12, 2012, 5:11 p.m.) Review request for Plasma. Changes --

Re: Review Request: Keep placeholder text visible when empty and focused

2012-12-10 Thread Aurélien Gâteau
> On Dec. 9, 2012, 1:01 p.m., Marco Martin wrote: > > in different platforms i seen both behaviors, hiding the text immediately > > or only when something is written. > > > > i am fine with this change, but i think the qwidget behavior (only > > ktextedit i think?) should be made the same > >

Re: Review Request: Keep placeholder text visible when empty and focused

2012-12-09 Thread Kevin Krammer
> On Dec. 9, 2012, 1:01 p.m., Marco Martin wrote: > > in different platforms i seen both behaviors, hiding the text immediately > > or only when something is written. > > > > i am fine with this change, but i think the qwidget behavior (only > > ktextedit i think?) should be made the same QLi

Re: Review Request: Keep placeholder text visible when empty and focused

2012-12-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107600/#review23194 --- in different platforms i seen both behaviors, hiding the text i