----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107600/#review23362 -----------------------------------------------------------
+1 from me, I've filed a similar review request for it (https://git.reviewboard.kde.org/r/104895/) but my proposal was met with quite some resistance and I've finally discarded my own request. One suggestion: maybe the placeholder should be dimmed to slightly lighter gray when the input widget receives the focus. This re-inforces the fact that the input widget has got the focus and that the placeholder isn't the real text, indeed. - Sebastian Gottfried On Dec. 12, 2012, 5:11 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107600/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2012, 5:11 p.m.) > > > Review request for Plasma. > > > Description > ------- > > This patch keeps the place holder text visible when a TextField is focused. > This is useful for situations where a text field is focused at startup. We > use it in Homerun for the search field. > > I filed a similar review-request for kdelibs KLineEdit and KTextEdit: > https://git.reviewboard.kde.org/r/107678/ > > > Diffs > ----- > > plasma/declarativeimports/plasmacomponents/qml/TextField.qml d19e7d8 > > Diff: http://git.reviewboard.kde.org/r/107600/diff/ > > > Testing > ------- > > Ran widgetgallery with the patch code, as can be seen in attached screenshot. > > > Screenshots > ----------- > > TextField with placeholder from Widget Gallery > http://git.reviewboard.kde.org/r/107600/s/872/ > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
