Re: Review Request: KDevelop sessions runner

2011-03-22 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100903/#review2100 --- looks good from my pov :) - Aaron J. On March 22, 2011, 10:01

Re: Review Request: KDevelop sessions runner

2011-03-22 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100903/ --- (Updated March 22, 2011, 10:01 a.m.) Review request for Plasma. Changes

Re: Review Request: KDevelop sessions runner

2011-03-22 Thread Sebastian Kügler
> On March 21, 2011, 2:45 p.m., Aaron J. Seigo wrote: > > runners/kdevelopsessions/kdevelopsessions.cpp, lines 46-56 > > > > > > to prevent krunner from waking up all the time, this should go into a > > slot connect

Re: Review Request: KDevelop sessions runner

2011-03-22 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100903/ --- (Updated March 22, 2011, 9:56 a.m.) Review request for Plasma. Changes -

Re: Review Request: KDevelop sessions runner

2011-03-21 Thread Sebastian Kügler
> On March 21, 2011, 2:45 p.m., Aaron J. Seigo wrote: > > runners/kdevelopsessions/kdevelopsessions.cpp, lines 46-56 > > > > > > to prevent krunner from waking up all the time, this should go into a > > slot connect

Re: Review Request: KDevelop sessions runner

2011-03-21 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100903/#review2080 --- runners/kdevelopsessions/kdevelopsessions.cpp

Re: Review Request: KDevelop sessions runner

2011-03-21 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100903/#review2079 --- The README file looks... not updated :) runners/kdevelopsessio