----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100903/#review2080 -----------------------------------------------------------
runners/kdevelopsessions/kdevelopsessions.cpp <http://git.reviewboard.kde.org/r/100903/#comment1730> to prevent krunner from waking up all the time, this should go into a slot connected to the prepare() signal; and then in a slot connected to teardown() delete the dirwatch. runners/kdevelopsessions/kdevelopsessions.cpp <http://git.reviewboard.kde.org/r/100903/#comment1729> not used? runners/kdevelopsessions/kdevelopsessions.cpp <http://git.reviewboard.kde.org/r/100903/#comment1731> needs some tidying :) runners/kdevelopsessions/kdevelopsessions.cpp <http://git.reviewboard.kde.org/r/100903/#comment1733> the 4 looks wrong. i suppose it should be term.at(9)? ('kdevelop ' is 9 chars long) runners/kdevelopsessions/kdevelopsessions.cpp <http://git.reviewboard.kde.org/r/100903/#comment1734> may as well remove "kdevelop " - Aaron J. On March 21, 2011, 12:51 p.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100903/ > ----------------------------------------------------------- > > (Updated March 21, 2011, 12:51 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > New KRunner plugin listing kdevelop sessions. Based on the same code for > kate, only changed the reading of the sessions. > > > Diffs > ----- > > runners/CMakeLists.txt 7bcb05f > runners/kdevelopsessions/CMakeLists.txt PRE-CREATION > runners/kdevelopsessions/Messages.sh PRE-CREATION > runners/kdevelopsessions/README PRE-CREATION > runners/kdevelopsessions/kdevelopsessions.cpp PRE-CREATION > runners/kdevelopsessions/kdevelopsessions.desktop PRE-CREATION > runners/kdevelopsessions/kdevelopsessions.h PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/100903/diff > > > Testing > ------- > > Started different sessions of kdevelop from KRunner, works just fine. > > > Thanks, > > Sebastian > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
