Re: Review Request: Ensure Plasma Desktop does not crash on exit with Qt 4.8

2011-11-22 Thread Thomas Lübking
> On Nov. 22, 2011, 9:24 a.m., Thomas Lübking wrote: > > plasma/private/containment_p.h, line 71 > > > > > > ibeg your pardon? > > to me this looks like you delete the same entry forever (what *will* > > crash a

Re: Review Request: Ensure Plasma Desktop does not crash on exit with Qt 4.8

2011-11-22 Thread Ben Cooksley
> On Nov. 22, 2011, 9:24 a.m., Thomas Lübking wrote: > > plasma/private/containment_p.h, line 71 > > > > > > ibeg your pardon? > > to me this looks like you delete the same entry forever (what *will* > > crash a

Re: Review Request: Ensure Plasma Desktop does not crash on exit with Qt 4.8

2011-11-22 Thread Aaron J. Seigo
> On Nov. 22, 2011, 9:24 a.m., Thomas Lübking wrote: > > plasma/private/containment_p.h, line 71 > > > > > > ibeg your pardon? > > to me this looks like you delete the same entry forever (what *will* > > crash a

Re: Review Request: Ensure Plasma Desktop does not crash on exit with Qt 4.8

2011-11-22 Thread Thomas Lübking
> On Nov. 22, 2011, 9:24 a.m., Thomas Lübking wrote: > > plasma/private/containment_p.h, line 71 > > > > > > ibeg your pardon? > > to me this looks like you delete the same entry forever (what *will* > > crash a

Re: Review Request: Ensure Plasma Desktop does not crash on exit with Qt 4.8

2011-11-22 Thread Ben Cooksley
> On Nov. 22, 2011, 9:24 a.m., Thomas Lübking wrote: > > plasma/private/containment_p.h, line 71 > > > > > > ibeg your pardon? > > to me this looks like you delete the same entry forever (what *will* > > crash a

Re: Review Request: Ensure Plasma Desktop does not crash on exit with Qt 4.8

2011-11-22 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103202/#review8384 --- plasma/private/containment_p.h

Re: Review Request: Ensure Plasma Desktop does not crash on exit with Qt 4.8

2011-11-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103202/#review8379 --- This review has been submitted with commit f02884d36bc6ff4db445

Re: Review Request: Ensure Plasma Desktop does not crash on exit with Qt 4.8

2011-11-22 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103202/#review8378 --- Ship it! this is massively bad on the part of qt :/ what a craz