----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103202/#review8384 -----------------------------------------------------------
plasma/private/containment_p.h <http://git.reviewboard.kde.org/r/103202/#comment7139> ibeg your pardon? to me this looks like you delete the same entry forever (what *will* crash at a point) since you don't remove it - should be "takeFirst", yesno? - Thomas Lübking On Nov. 22, 2011, 7:39 a.m., Ben Cooksley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103202/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2011, 7:39 a.m.) > > > Review request for kdelibs and Plasma. > > > Description > ------- > > Qt 4.8 contains changes which break qDeleteAll() in certain scenarios. This > patch fixes one of those scenarios to ensure that Plasma Desktop does not > crash on quit or logout. > > > Diffs > ----- > > plasma/private/containment_p.h 4025bf4 > > Diff: http://git.reviewboard.kde.org/r/103202/diff/diff > > > Testing > ------- > > Compiled, Plasma Desktop no longer crashes on exit. > > > Thanks, > > Ben Cooksley > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
