Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-11-09 Thread John Layt
> On Nov. 9, 2011, 10:33 a.m., David Narváez wrote: > > If there are no more comments against or in favor of this patch, I'm > > assuming everyone is OK with it so I'll commit this patch. > > Sergio Luis Martins wrote: > Ok. > > Please add a note in the TODO that we'll need to look

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-11-09 Thread Sergio Luis Martins
> On Nov. 9, 2011, 10:33 a.m., David Narváez wrote: > > If there are no more comments against or in favor of this patch, I'm > > assuming everyone is OK with it so I'll commit this patch. Ok. Please add a note in the TODO that we'll need to look at this again when using the kdepimlibs library

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-11-09 Thread Sergio Luis Martins
> On Nov. 1, 2011, 7:39 p.m., Sergio Luis Martins wrote: > > A Calendar object is supposed to mirror what's in akonadi, so we can't > > change Incidence's timezones in there. > > > > I think this should be resolved in the presentation layer, converting to > > the local timezone there ( KSystem

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-11-09 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102997/#review8038 --- If there are no more comments against or in favor of this patch,

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-11-08 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102997/ --- (Updated Nov. 8, 2011, 9:14 a.m.) Review request for Plasma and Sergio Lui

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-11-06 Thread David Narváez
> On Nov. 1, 2011, 7:39 p.m., Sergio Luis Martins wrote: > > A Calendar object is supposed to mirror what's in akonadi, so we can't > > change Incidence's timezones in there. > > > > I think this should be resolved in the presentation layer, converting to > > the local timezone there ( KSystem

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-11-01 Thread David Narváez
> On Nov. 1, 2011, 7:39 p.m., Sergio Luis Martins wrote: > > A Calendar object is supposed to mirror what's in akonadi, so we can't > > change Incidence's timezones in there. > > > > I think this should be resolved in the presentation layer, converting to > > the local timezone there ( KSystem

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-11-01 Thread Sergio Luis Martins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102997/#review7834 --- A Calendar object is supposed to mirror what's in akonadi, so we

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-10-30 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102997/ --- (Updated Oct. 31, 2011, 6:57 a.m.) Review request for Plasma and Sergio Lu

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-10-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102997/#review7757 --- Ship it! Ship It! - Aaron J. Seigo On Oct. 30, 2011, 3:31 a.