> On Nov. 1, 2011, 7:39 p.m., Sergio Luis Martins wrote: > > A Calendar object is supposed to mirror what's in akonadi, so we can't > > change Incidence's timezones in there. > > > > I think this should be resolved in the presentation layer, converting to > > the local timezone there ( KSystemTimeZones::local() ) > > David Narváez wrote: > What would be the purpose of sending a TimeSpec to the CalendarModel then? > > David Narváez wrote: > To pick up on this review again, notice that moving the timezone logic to > the Calendar Applet (the presentation layer) implies changing the whole > concept of the Calendar Data Engine. Currently, you can fetch events from > date A to date B using queries to the Calendar Data Engine, but if all > timezone information is handled from the presentation side, then you'd need > to query with time shifts (e.g., in my country where we are at GMT -5, I'd > need to ask for events between 5:00 am today and 5:00 am tomorrow to have my > events for the day). > > A change of this size would requiere a large discussion. As the proposed > patch already deals with code meant to be migrated, and it fixes a bug, I > propose we merge this patch and then rethink this presentation/model issue. > I'd be very happy to help redesign these parts, but I'd be even happier to > close the bug in question.
My guess is that they are leftovers from the time when libkcal had both a KDateTime and a QDateTime interface. Methods receiving a QDateTime needed to use a timespec. - Sergio Luis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102997/#review7834 ----------------------------------------------------------- On Nov. 8, 2011, 9:14 a.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102997/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2011, 9:14 a.m.) > > > Review request for Plasma and Sergio Luis Martins. > > > Description > ------- > > Adjust KDateTimes after finding out the type of incidence added. Also adjust > KDateTimes after a change in the Calendar TimeSpec. > > > This addresses bug 279427. > http://bugs.kde.org/show_bug.cgi?id=279427 > > > Diffs > ----- > > plasma/generic/dataengines/calendar/akonadi/calendar.cpp 67c12e9 > > Diff: http://git.reviewboard.kde.org/r/102997/diff/diff > > > Testing > ------- > > 1. Add an event in any timezone distinct from the local timezone (you can do > that in KOrganizer) > 2. Check the start and end times of the event in the calendar > > Not sure how to test changing timezones from Plasma, so proposed patch is > based on what I think we should do in such a case. > > > Thanks, > > David Narváez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
