Re: Review Request: Add support for building libplasma with GLES2

2011-03-02 Thread Sebastian Kügler
On Tuesday, March 01, 2011 02:29:13 Jammy Zhou wrote: > As Martin mentioned, the direct GL dependency has been removed in my new > patch, and the original "BUILD_PLASMA_WITH_OPENGLES" option I added is not > needed any more in this case. Even better :) -- sebas http://www.kde.org | http://vizZzi

Re: Review Request: Add support for building libplasma with GLES2

2011-02-28 Thread Jammy Zhou
Hi Sebas, As Martin mentioned, the direct GL dependency has been removed in my new patch, and the original "BUILD_PLASMA_WITH_OPENGLES" option I added is not needed any more in this case. Cheers, Jammy On Mon, Feb 28, 2011 at 11:33 PM, Martin Gräßlin wrote: > > - Ursprüngliche Mitteilung -

Re: Review Request: Add support for building libplasma with GLES2

2011-02-28 Thread Martin Gräßlin
- Ursprüngliche Mitteilung - > On Friday, February 25, 2011 04:29:36 Jammy Zhou wrote: > > --- > > This is an automatically generated e-mail. To reply, visit: > > http://git.reviewboard.kde.org/r/100705/ > > --

Re: Review Request: Add support for building libplasma with GLES2

2011-02-28 Thread Sebastian Kügler
On Friday, February 25, 2011 04:29:36 Jammy Zhou wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100705/ > --- > Update the p

Re: Review Request: Add support for building libplasma with GLES2

2011-02-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100705/#review1693 --- Ship it! to me seems good. filling the background of black is s

Re: Review Request: Add support for building libplasma with GLES2

2011-02-24 Thread Jammy Zhou
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100705/ --- (Updated Feb. 25, 2011, 3:29 a.m.) Review request for kdelibs and Plasma.

Re: Review Request: Add support for building libplasma with GLES2

2011-02-24 Thread Jammy Zhou
> On Feb. 23, 2011, 5:29 p.m., Martin Gräßlin wrote: > > The GLApplet seems to be unmaintained and is nowhere used in KDE (see > > http://lxr.kde.org/ident?i=GLApplet ). There was once one demo applet using > > it, but it has vanished. > > > > GLApplet uses OpenGL only for glClear before passi

Re: Review Request: Add support for building libplasma with GLES2

2011-02-24 Thread Martin Gräßlin
> On Feb. 23, 2011, 5:29 p.m., Martin Gräßlin wrote: > > The GLApplet seems to be unmaintained and is nowhere used in KDE (see > > http://lxr.kde.org/ident?i=GLApplet ). There was once one demo applet using > > it, but it has vanished. > > > > GLApplet uses OpenGL only for glClear before passi

Re: Review Request: Add support for building libplasma with GLES2

2011-02-23 Thread Jammy Zhou
> On Feb. 23, 2011, 5:29 p.m., Martin Gräßlin wrote: > > The GLApplet seems to be unmaintained and is nowhere used in KDE (see > > http://lxr.kde.org/ident?i=GLApplet ). There was once one demo applet using > > it, but it has vanished. > > > > GLApplet uses OpenGL only for glClear before passi

Re: Review Request: Add support for building libplasma with GLES2

2011-02-23 Thread Jammy Zhou
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100705/ --- (Updated Feb. 24, 2011, 2:07 a.m.) Review request for kdelibs and Plasma.