----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100705/#review1693 -----------------------------------------------------------
Ship it! to me seems good. filling the background of black is something that eventually should do a reimplementation. - Marco On Feb. 25, 2011, 3:29 a.m., Jammy Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100705/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2011, 3:29 a.m.) > > > Review request for kdelibs and Plasma. > > > Summary > ------- > > After build kwin with GLES2 code path, the kwin binary still has dependency > on libGL.so, which is introduced by libplasma.so. Then we also need to add > GLES2 support to libplasma, so that kwin/plasma only has dependency on > libGLESv2.so in this case. > > The new option "BUILD_PLASMA_WITH_OPENGLES" added in attached patch is > disabled by default, and distributions can turn it on when do packaging for > OpenGL ES2.0 support. > > > Diffs > ----- > > CMakeLists.txt b8d53de > includes/CMakeLists.txt 9954c37 > plasma/CMakeLists.txt 8e6b0d7 > plasma/glapplet.cpp 00d7caf > > Diff: http://git.reviewboard.kde.org/r/100705/diff > > > Testing > ------- > > After turn the "BUILD_PLASMA_WITH_OPENGLES" option on, kwin-gles has no > dependency on libGL.so now. And by default, libplasma still depends on > libGL.so when run ldd. > > > Thanks, > > Jammy > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
