Re: Review Request: plasma-thunderbolt

2019-05-21 Thread Jonathan Riddell
On Wed, May 15, 2019 at 03:27:07PM +0200, Daniel Vrátil wrote: > plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt KCM > for Plasma. I initially submitted the code as a patch against plasma-desktop > [0], where it got reviewed, but it was ultimately decided to better put it

Re: Review Request: plasma-thunderbolt

2019-05-16 Thread Daniel Vrátil
On Wednesday, 15 May 2019 23:08:57 CEST Albert Astals Cid wrote: > El dimecres, 15 de maig de 2019, a les 15:27:07 CEST, Daniel Vrátil va escriure: > > Hi all, > > > > plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt > > KCM for Plasma. I initially submitted the code as a

Re: Review Request: plasma-thunderbolt

2019-05-16 Thread Daniel Vrátil
On Wednesday, 15 May 2019 15:55:01 CEST Friedrich W. H. Kossebau wrote: > Am Mittwoch, 15. Mai 2019, 15:27:07 CEST schrieb Daniel Vrátil: > > Thus I'd kindly ask you to take one more look at the codebase [1] and let > > me know if there are any more issues to fix, or if we can proceed to > > includ

Re: Review Request: plasma-thunderbolt

2019-05-15 Thread Albert Astals Cid
El dimecres, 15 de maig de 2019, a les 15:27:07 CEST, Daniel Vrátil va escriure: > Hi all, > > plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt KCM > for Plasma. I initially submitted the code as a patch against plasma-desktop > [0], where it got reviewed, but it was ulti

Re: Review Request: plasma-thunderbolt

2019-05-15 Thread Luca Beltrame
In data mercoledì 15 maggio 2019 15:27:07 CEST, Daniel Vrátil ha scritto: > Thus I'd kindly ask you to take one more look at the codebase [1] and let me > know if there are any more issues to fix, or if we can proceed to include > this in the next Plasma release. The repository at this point is m

Re: Review Request: plasma-thunderbolt

2019-05-15 Thread Friedrich W. H. Kossebau
Am Mittwoch, 15. Mai 2019, 15:27:07 CEST schrieb Daniel Vrátil: > Thus I'd kindly ask you to take one more look at the codebase [1] and let me > know if there are any more issues to fix, or if we can proceed to include > this in the next Plasma release. Pushed some small fixes to toplevel CMakeLis

Re: Review Request 121010: Keep track of notifications that were covered by a fullscreen window

2018-01-14 Thread Kai Uwe Broulik
> On Nov. 6, 2014, 12:12 nachm., Martin Flöser wrote: > > applets/notifications/plugin/notificationshelper.cpp > > Lines 169-173 (patched) > > > > > > note: this code causes roundtrips to the X server. At the sam

Re: Review Request 130247: Show root items in kicker menu. Related to #358291

2017-11-14 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130247/#review103843 --- Please use https://phabricator.kde.org/differential/diff/cre

Re: Review Request 126322: [ToolTip] Dismiss tooltip when item becomes invisible

2017-08-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126322/ --- (Updated Aug. 29, 2017, 8:58 nachm.) Status -- This change has been

Re: Review Request 126061: [Menu] Popup above parent if would exceed screen boundaries

2017-08-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126061/ --- (Updated Aug. 29, 2017, 8:57 nachm.) Status -- This change has been

Re: Review Request 130208: Add menu with "Copy to Clipboard" to the About System module

2017-08-03 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130208/ --- (Updated Aug. 3, 2017, 9:43 a.m.) Status -- This change has been dis

Re: Review Request 130208: Add menu with "Copy to Clipboard" to the About System module

2017-08-03 Thread Gregor Mi
> On July 31, 2017, 3:59 a.m., Anthony Fieroni wrote: > > Modules/about-distro/src/Module.cpp, line 198 > > > > > > Plasma now depends on minimum 5.30, you can remove this check. Plasma > > team now use Phabrica

Re: Review Request 130208: Add menu with "Copy to Clipboard" to the About System module

2017-07-31 Thread Gregor Mi
> On July 31, 2017, 9:52 a.m., Sebastian Kügler wrote: > > Reviewboard isn't used for Plasma anymore. Would you mind putting this > > patch up on phabricator so it can be reviewed there? Sure, I will put this patch on phabricator. I guess, the file src/kde/workspace/kinfocenter/.reviewboardrc

Re: Review Request 130206: systemsettings tooltip items non italic

2017-07-31 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130206/ --- (Updated Juli 31, 2017, 12:11 nachm.) Status -- This change has been

Re: Review Request 130205: View Styles

2017-07-31 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130205/ --- (Updated Juli 31, 2017, 12:09 nachm.) Status -- This change has been

Re: Review Request 130205: View Styles

2017-07-31 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130205/#review103514 --- Ship it! Ah, my bad. That's fine, then. :) - Sebastian K

Re: Review Request 130208: Add menu with "Copy to Clipboard" to the About System module

2017-07-31 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130208/#review103513 --- Reviewboard isn't used for Plasma anymore. Would you mind pu

Re: Review Request 130208: Add menu with "Copy to Clipboard" to the About System module

2017-07-31 Thread Elvis Angelaccio
> On July 30, 2017, 3:44 p.m., Gregor Mi wrote: > > Ideally, I would like to add a second action to the menu: "About KDE", > > which should show the default "About KDE" dialog. But I don't know how to > > access this default action. > But I don't know how to access this default action. Use `K

Re: Review Request 130208: Add menu with "Copy to Clipboard" to the About System module

2017-07-30 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130208/#review103510 --- Modules/about-distro/src/Module.cpp (line 198)

Re: Review Request 130208: Add menu with "Copy to Clipboard" to the About System module

2017-07-30 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130208/#review103509 --- Ideally, I would like to add a second action to the menu: "A

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

2017-07-29 Thread Jiri Bohac
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129691/ --- (Updated July 29, 2017, 10:26 a.m.) Status -- This change has been m

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

2017-07-28 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129691/#review103505 --- Ship it! Ship It! - Sebastian Kügler On Dec. 27, 2016,

Re: Review Request 130205: View Styles

2017-07-28 Thread Andreas Kainz
> On Juli 28, 2017, 9:14 vorm., Sebastian Kügler wrote: > > Why? > > > > The mode chooser is hidden well enough that it doesn't produce visual noise > > and not a lot of extra burden on the user (since there's UI for switching > > anyway, 2 or 3 options doesn't make it a lot lighter). Moreover

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

2017-07-28 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129691/#review103497 --- So can we commit this then? - Albert Astals Cid On Dec. 2

Re: Review Request 130206: systemsettings tooltip items non italic

2017-07-28 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130206/#review103489 --- Ship it! Ship It! - Sebastian Kügler On July 26, 2017,

Re: Review Request 130205: View Styles

2017-07-28 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130205/#review103488 --- Why? The mode chooser is hidden well enough that it doesn't

Re: Review Request 130163: Add ConsoleKit2 support for launching Wayland sessions

2017-06-19 Thread Eric Koegel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130163/ --- (Updated June 20, 2017, 5:58 a.m.) Status -- This change has been di

Re: Review Request 130163: Add ConsoleKit2 support for launching Wayland sessions

2017-06-19 Thread Martin Flöser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130163/#review103347 --- We are currently in the process of fading out reviewboard. C

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

2017-06-17 Thread Martin Koller
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129838/ --- (Updated June 17, 2017, 1:58 p.m.) Review request for Plasma and Kåre Sär

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

2017-06-17 Thread Martin Koller
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129838/ --- (Updated June 17, 2017, 1:58 p.m.) Status -- This change has been ma

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

2017-06-11 Thread Kåre Särs
> On Feb. 8, 2017, 3:47 p.m., Marco Martin wrote: > > any update on this? > > Martin Koller wrote: > Is there any reason this is held back ? > > Marco Martin wrote: > No, could you push this? Sorry! I have totally missed the updated comments :( Please commit. - Kåre ---

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

2017-06-11 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129838/#review103314 --- Ship it! Ship It! - Kåre Särs On Jan. 15, 2017, 2:36 p

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

2017-06-11 Thread Marco Martin
> On Feb. 8, 2017, 3:47 p.m., Marco Martin wrote: > > any update on this? > > Martin Koller wrote: > Is there any reason this is held back ? No, could you push this? - Marco --- This is an automatically generated e-mail. To reply,

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

2017-06-11 Thread Martin Koller
> On Feb. 8, 2017, 3:47 p.m., Marco Martin wrote: > > any update on this? Is there any reason this is held back ? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129838/#review1

Re: Review Request 130129: Don't upscale jpeg images when creating thumbnails

2017-06-03 Thread Alexander Volkov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130129/ --- (Updated June 3, 2017, 2:18 p.m.) Status -- This change has been mar

Re: Review Request 130129: Don't upscale jpeg images when creating thumbnails

2017-06-03 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130129/#review103268 --- Ship it! Ship It! - Christoph Feck On June 3, 2017, 11

Re: Review Request 129851: JpegCreator: Use Qt's support for fast downscaling and auto-rotation

2017-05-14 Thread Alex Bikadorov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129851/#review103212 --- FYI: https://bugs.kde.org/show_bug.cgi?id=379817 - Alex Bik

Re: Review Request 130006: Avoid showing wrong timezone suffix in krunner time

2017-05-08 Thread Ronnie Thomas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130006/ --- (Updated May 8, 2017, 3:09 p.m.) Status -- This change has been disc

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130094/ --- (Updated April 21, 2017, 3:57 p.m.) Status -- This change has been d

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
> On April 21, 2017, 11:12 a.m., Kai Uwe Broulik wrote: > > src/platformtheme/kdeplatformtheme.cpp, line 122 > > > > > > Why is this only built in 5.7 and below? Was this removed in 5.8? > > (didn't check Qt cod

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Kai Uwe Broulik
> On April 21, 2017, 9:12 vorm., Kai Uwe Broulik wrote: > > Thanks for your patch! > > > > Plasma reviews are nowadays handled on https://phabricator.kde.org/ - could > > you perhaps upload it there again? I just don't want it to get lost here :/ > > > > Also, I'm not sure about having a separ

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
> On April 21, 2017, 11:12 a.m., Kai Uwe Broulik wrote: > > Thanks for your patch! > > > > Plasma reviews are nowadays handled on https://phabricator.kde.org/ - could > > you perhaps upload it there again? I just don't want it to get lost here :/ > > > > Also, I'm not sure about having a separ

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
> On April 21, 2017, 11:12 a.m., Kai Uwe Broulik wrote: > > Thanks for your patch! > > > > Plasma reviews are nowadays handled on https://phabricator.kde.org/ - could > > you perhaps upload it there again? I just don't want it to get lost here :/ > > > > Also, I'm not sure about having a separ

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130094/#review103073 --- Thanks for your patch! Plasma reviews are nowadays handled

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
> On April 21, 2017, 11:01 a.m., Mark Gaiser wrote: > > src/platformtheme/kdeplatformtheme.cpp, line 422 > > > > > > foreach OR for (... : qAsConst(m_standardPathItems)) > > Or use std::vector and keep the fo

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Eugene Shalygin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130094/ --- (Updated April 21, 2017, 11:11 a.m.) Review request for Plasma. Changes

Re: Review Request 130094: Implement QPlatformTheme::fileIconPixmap()

2017-04-21 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130094/#review103072 --- src/platformtheme/kdeplatformtheme.cpp (line 421)

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

2017-03-19 Thread Martin Koller
> On Jan. 16, 2017, 8:40 a.m., Kåre Särs wrote: > > The current/old version uses "connectSource(source)" to add the CPUs when > > they are added in onSourceAdded, but that is not good if the sources are > > added before SystemLoadViewer.qml (a problem when adding a second > > SytemLoadViewer)

Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

2017-03-08 Thread Leslie Zhai
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129994/ --- (Updated March 8, 2017, 6:43 p.m.) Status -- This change has been ma

Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

2017-03-08 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129994/#review102764 --- Ship it! Ship It! - David Edmundson On March 8, 2017,

Re: Review Request 129995: Fix KillRunner Memory leak

2017-03-07 Thread Leslie Zhai
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129995/ --- (Updated March 8, 2017, 2:43 a.m.) Status -- This change has been ma

Re: Review Request 129995: Fix KillRunner Memory leak

2017-03-07 Thread Leslie Zhai
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129995/ --- (Updated 三月 8, 2017, 10:42 a.m.) Review request for Plasma, Aleix Pol Gon

Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

2017-03-07 Thread Leslie Zhai
> On 三月 7, 2017, 7:45 p.m., Kai Uwe Broulik wrote: > > applets/appmenu/lib/appmenuapplet.cpp, line 167 > > > > > > Prefer !ctx instead of comparing with nullptr > > > > Also, could you move the check up

Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

2017-03-07 Thread Leslie Zhai
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129994/ --- (Updated 三月 8, 2017, 10:17 a.m.) Review request for Plasma, Kai Uwe Broul

Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null

2017-03-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129994/#review102749 --- applets/appmenu/lib/appmenuapplet.cpp (line 167)

Re: Review Request 129995: Fix KillRunner Memory leak

2017-03-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129995/#review102746 --- Fix it, then Ship it! runners/kill/killrunner.cpp (line

Re: Review Request 127409: Make sure we're not forcing the window to be created prematurely

2017-03-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127409/ --- (Updated mar. 3, 2017, 4:52 p.m.) Status -- This change has been dis

Re: Review Request 127408: Make sure the QPlatformWindow doesn't get initialized prematurely.

2017-03-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127408/ --- (Updated mar. 3, 2017, 4:50 p.m.) Status -- This change has been dis

Re: Review Request 126946: Remove specific X11 code

2017-03-01 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126946/ --- (Updated March 1, 2017, 10:30 a.m.) Status -- This change has been d

Re: Review Request 128426: Support OpenGL 3.2 Core profile in FadingNode shaders

2017-02-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128426/ --- (Updated March 1, 2017, 2:33 a.m.) Status -- This change has been di

Re: Review Request 123300: Make the dataengine alignment timer more precise

2017-02-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123300/ --- (Updated Feb. 25, 2017, 11:59 p.m.) Status -- This change has been m

Re: Review Request 126946: Remove specific X11 code

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126946/#review102606 --- Patch doesn't apply anymore. - Albert Astals Cid On Feb.

Re: Review Request 127408: Make sure the QPlatformWindow doesn't get initialized prematurely.

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127408/#review102603 --- Aleix? - Albert Astals Cid On March 17, 2016, 2:16 a.m.,

Re: Review Request 127409: Make sure we're not forcing the window to be created prematurely

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127409/#review102600 --- What's the status of this? Should it be commited? improved?

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-23 Thread Pascal VITOUX
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129917/ --- (Updated Feb. 23, 2017, 1:12 p.m.) Status -- This change has been ma

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-22 Thread Pascal VITOUX
> On fév. 22, 2017, 12:31 matin, David Edmundson wrote: > > Ship It! I cannot commit myself (no account), so if everyone is ok, can someone do it for me ? I would be grateful - Pascal --- This is an automatically generated e-mail. To r

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129917/#review102571 --- Ship it! Ship It! - David Edmundson On Feb. 7, 2017, 9

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129917/#review102567 --- Sebas can this be commited now or you have more concerns? -

Re: Review Request 129955: fix off by one in the socket filename

2017-02-16 Thread Damjan Georgievski
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129955/ --- (Updated Feb. 17, 2017, 1:50 a.m.) Status -- This change has been ma

Re: Review Request 129955: fix off by one in the socket filename

2017-02-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129955/#review102534 --- Ship it! Good catch! I was curious and look a bit about i

Re: Review Request 129955: fix off by one in the socket filename

2017-02-16 Thread Damjan Georgievski
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129955/ --- (Updated Feb. 17, 2017, 12:23 a.m.) Review request for KDE Frameworks and

Re: Review Request 129867: Complete oxygen look and feel

2017-02-08 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129867/ --- (Updated Feb. 8, 2017, 8:25 p.m.) Status -- This change has been mar

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

2017-02-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126016/#review102489 --- please post this again on phabricator if is still relevant

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

2017-02-08 Thread Johan Ouwerkerk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126016/ --- (Updated Feb. 8, 2017, 4:02 p.m.) Status -- This change has been dis

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

2017-02-08 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125773/ --- (Updated Feb. 8, 2017, 4:02 p.m.) Status -- This change has been dis

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

2017-02-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125773/#review102488 --- please post this again on phabricator if is still relevant

Re: Review Request 123682: Plasma-Desktop: Port kcm fonts to QML.

2017-02-08 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123682/ --- (Updated Feb. 8, 2017, 4:01 p.m.) Status -- This change has been dis

Re: Review Request 123682: Plasma-Desktop: Port kcm fonts to QML.

2017-02-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123682/#review102487 --- please post this again on phabricator if is still relevant

Re: Review Request 125199: change KCM behavior as the ksmserver default for session restore changed

2017-02-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125199/#review102486 --- any news on this? please post this again on phabricator if i

Re: Review Request 125198: by default do not restore the previous session on next login

2017-02-08 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125198/ --- (Updated Feb. 8, 2017, 4 p.m.) Status -- This change has been discar

Re: Review Request 125199: change KCM behavior as the ksmserver default for session restore changed

2017-02-08 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125199/ --- (Updated Feb. 8, 2017, 4:01 p.m.) Status -- This change has been dis

Re: Review Request 125198: by default do not restore the previous session on next login

2017-02-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125198/#review102484 --- any news on this? please post this again on phabricator if i

Re: Review Request 128392: [kickoff] kickoff should use icons from icon theme

2017-02-08 Thread Andrey Bondrov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128392/ --- (Updated Feb. 8, 2017, 3:59 p.m.) Status -- This change has been dis

Re: Review Request 128392: [kickoff] kickoff should use icons from icon theme

2017-02-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128392/#review102483 --- please post this again on phabricator if is still relevant

Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature

2017-02-08 Thread Nico Rodsevich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126720/ --- (Updated Feb. 8, 2017, 3:56 p.m.) Status -- This change has been dis

Re: Review Request 126720: Adds QML's PlasmaCore.SVG CustomColor feature

2017-02-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126720/#review102482 --- please post this again on phabricator if is still relevant p

Re: Review Request 128109: Provide demo/preview for checkable menu items too [WIP]

2017-02-08 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128109/ --- (Updated Feb. 8, 2017, 3:53 p.m.) Status -- This change has been dis

Re: Review Request 128109: Provide demo/preview for checkable menu items too [WIP]

2017-02-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128109/#review102481 --- please post this again on phabricator if is still relevant

Re: Review Request 128417: Retain original task button sort order when in manual sort mode and plasmashell restarts.

2017-02-08 Thread Xuân Baldauf
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128417/ --- (Updated Feb. 8, 2017, 3:50 p.m.) Status -- This change has been dis

Re: Review Request 128417: Retain original task button sort order when in manual sort mode and plasmashell restarts.

2017-02-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128417/#review102480 --- please post this again on phabricator if is still relevant

Re: Review Request 121207: Port the notes editor to KDevPlatform

2017-02-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121207/#review102478 --- please post this again on phabricator if is still relevant

Re: Review Request 121208: Port the KConfigXtEditor to KDevPlatform

2017-02-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121208/#review102479 --- please post this again on phabricator if is still relevant

Re: Review Request 121208: Port the KConfigXtEditor to KDevPlatform

2017-02-08 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121208/ --- (Updated Feb. 8, 2017, 3:49 p.m.) Status -- This change has been dis

Re: Review Request 121207: Port the notes editor to KDevPlatform

2017-02-08 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121207/ --- (Updated Feb. 8, 2017, 3:49 p.m.) Status -- This change has been dis

Re: Review Request 129095: KCM Cursor fix button size for select size

2017-02-08 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129095/ --- (Updated Feb. 8, 2017, 3:48 p.m.) Status -- This change has been dis

Re: Review Request 129095: KCM Cursor fix button size for select size

2017-02-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129095/#review102477 --- please post it again to phabricator if is still relevant -

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

2017-02-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129838/#review102476 --- any update on this? - Marco Martin On Jan. 15, 2017, 2:36

Re: Review Request 126902: Set buddy widgets in Font KCM

2017-02-08 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126902/ --- (Updated Feb. 8, 2017, 3:43 p.m.) Status -- This change has been mar

Re: Review Request 129867: Complete oxygen look and feel

2017-02-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129867/#review102475 --- Ship it! should be either pushed quicly or moved to phabr

Re: Review Request 129315: Don't install plasmoid desktop files as services

2017-02-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129315/ --- (Updated Feb. 8, 2017, 3:37 p.m.) Status -- This change has been dis

  1   2   3   4   5   6   7   8   9   10   >