Re: Menu branch

2013-04-24 Thread Ignat Semenov
Hello guys, The branch has been merged to master with a few more cleanups (namely fixed missing or incorrect "What's this" for the newly added items; changed the page name to "Icons"; changed the page icon to "preferences-desktop-icons"). Thanks goes to Sho for reviewing the branch and nitpicki

Re: Menu branch

2013-04-21 Thread Ignat Semenov
OK forget that, just talked to aseigo and he told me there still is a usecase (and probably a few of those) for manual arrangement in the standalone mode. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-de

Re: Menu branch

2013-04-21 Thread Ignat Semenov
Done, Mr Eagle Eye ;) OK I also need to add a menu to the list view, right? Currently there is no way to change sorting via the context menu. Arrangement and alignment do not make sense in the list view context, but sorting does. One more thing: In the standalone applet mode, but with an iconv

Re: Menu branch

2013-04-21 Thread Eike Hein
On Sunday 21 April 2013 12:30:20 Ignat Semenov wrote: > Done! Nice work. Two tiny bits left: - "Align Icons" could just be "Align" in the context menu (the parent menu name, "Icons", already provides this context). - I don't think we need a divider between the "Descending" and the "Folders F

Re: Menu branch

2013-04-21 Thread Ignat Semenov
Done! Best regards, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Menu branch

2013-04-20 Thread Eike Hein
Hi again, had a look at the diffs now. Looking good to me from the code side, but a couple of thoughts on the UI: - I think the split is working out as well as we had hoped, but the devil is in the details ... on the dialog page: - The repetition of "Sorting" between the group box title and

Re: Menu branch

2013-04-20 Thread Eike Hein
On Friday 19 April 2013 11:32:48 Ignat Semenov wrote: > setLayout() and setAlignment() both trigger a complete relayout of the view. > Relayouting the view twice is suboptimal, however, in the code there is a > 10ms timer to delay the relayout so as not to block the caller. Should that > timer be e

Re: Menu branch

2013-04-19 Thread Ignat Semenov
Hello, git.k.o is finally up again, so here we go: - Split the flow enum in two - a mega-patch with a mega-commit-message - Re-did the UI with 4 categories Concerns: setLayout() and setAlignment() both trigger a complete relayout of the view. Relayouting the view twice is suboptimal, however,

Re: Menu branch

2013-04-18 Thread Eike Hein
On Thursday 18 April 2013 00:20:06 Ignat Semenov wrote: > A UI draft: > > http://imagebin.org/254401 > > Maybe move "Icon size" to the "Arrangement" section? Looks better than before, if you ask me. I agree that "Icon size" should be moved to "Arrangement", and I'm wondering if "Layout:" should

Re: Menu branch

2013-04-18 Thread Eike Hein
On Wednesday 17 April 2013 22:20:26 Ignat Semenov wrote: > - setCurrentItem() - which one did you like better, monolithic > setCurrentItem(), find() and then set() depending on find(), or the last > one with set() being unnecessary? For me, it's usually "code what to do not > how", but this time I

Re: Menu branch

2013-04-17 Thread Ignat Semenov
A UI draft: http://imagebin.org/254401 Maybe move "Icon size" to the "Arrangement" section? Best regards, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Menu branch

2013-04-17 Thread Ignat Semenov
Hello, Wow that was fast :) Glad to see you coding for plasma, your experience is very welcome (not to say I finally have someone to poke to death with design questions ;) ) - Display options is indeed a mess, well is it ok to mix combos and checkboxes together? i.e. 2 combos, 1 checkobox, the

Re: Menu branch

2013-04-17 Thread Eike Hein
Hi, the branch generally looks OK to me, however: - Display -> Icons in the config dialog is getting to be pretty messy; with that abundance of options it might make sense to split things into group boxes for Arrangement (flow, grid, lock) and Sorting (role, direction, folders first) to a

Re: Menu branch

2013-04-17 Thread Ignat Semenov
A small update: I think that the setCurrentItem() abstraction is superfluous, not to mention that the name coincides with that of a QComboBox member function, thus I've put the workaround in findComboboxItem(), so now it is clear what is worked around, and once qt5 comes, it will be easy to swa

Menu branch

2013-04-17 Thread Ignat Semenov
Hello plasma devs and users, Please review the plasma/isemenov/menu branch. Based on #306537 but goes a bit further than that. Fixes: "Arrange icons" (flow configuration) added to the context menu "Sort order" and "folders first" added to the config UI Update the