Re: Review Request 106448: replace old kickoff with kickoff-qml

2014-08-10 Thread Ivan Čukić
> While my earlier notes are valid purely from a generic Plasma module POV, > there may be a case for why favorites deserve special treatment and should > be shared between launchers after all: The basic menu data already is. > Perhaps favorites aren't launcher-specific configuration, but an exten

Re: Review Request 106448: replace old kickoff with kickoff-qml

2014-08-09 Thread Eike Hein
So I've been thinking about this some more (thanks, insomnia) ... While my earlier notes are valid purely from a generic Plasma module POV, there may be a case for why favorites deserve special treatment and should be shared between launchers after all: The basic menu data already is. Perhaps fa

Re: Review Request 106448: replace old kickoff with kickoff-qml

2014-08-09 Thread Ivan Čukić
I have reverted the patch in Kickoff (it would be bad to introduce something in 5.1, and remove it later) Kickoff is back to its old behaviour - global only favourites, shared across instances. -- Cheerio, Ivan KDE, ivan.cukic at kde.org, http://ivan.fomentgroup.org/ gpg key id: 850B6F76,

Re: Review Request 106448: replace old kickoff with kickoff-qml

2014-08-08 Thread Eike Hein
On 08/08/2014 09:00 PM, Ivan Čukić wrote: I don't think it is that simple - in this particular example, the per-activity stuff lives alongside the non-per-activity ones. You can define a favourite to be only on a specific activity, or to be on all. Hm, I see - I didn't know about the "or on a

Re: Review Request 106448: replace old kickoff with kickoff-qml

2014-08-08 Thread Ivan Čukić
> Wild idea: Maybe we sort of need to integrate activity stuff > at the KConfig level even? So keys can have an activity- > specific value? I think that would be an overkill. And would move kconfig much higher in the tier-level organization. Hmh, or you were saying to put it in plasma config int

Re: Review Request 106448: replace old kickoff with kickoff-qml

2014-08-08 Thread Eike Hein
On 08/08/2014 08:47 PM, Eike Hein wrote: Wild idea: Maybe we sort of need to integrate activity stuff at the KConfig level even? So keys can have an activity- specific value? Or, you know, a less ambitious variant: Plasma widgets are implicitly required to be implemented in a way that allows

Re: Review Request 106448: replace old kickoff with kickoff-qml

2014-08-08 Thread Eike Hein
On 08/08/2014 08:40 PM, Ivan Čukić wrote: 2. Config-file based - per-instance, each applet will implement its own mechanism for favourites, like it currently is. Wild idea: Maybe we sort of need to integrate activity stuff at the KConfig level even? So keys can have an activity- specific valu

Re: Review Request 106448: replace old kickoff with kickoff-qml

2014-08-08 Thread Ivan Čukić
> it is true that would be needed to be applet specific, or it creates some > problems, but linking to activity looks like the good way to go for me Possible to do, but there is no point in having this kept in a central storage, and having the round-trips to the service and back every time the

Re: Review Request 106448: replace old kickoff with kickoff-qml

2014-08-08 Thread Ivan Čukić
polish it > for KDE 4.10. the qml plasmoid is still using the old model code (though > slightly adjusted). This could cause issues for the c++ menu launcher > "simpleapplet"...I'm not using it but actually it doesn't even compile. > Probably would be better to port it

Re: Review Request 106448: replace old kickoff with kickoff-qml

2014-08-08 Thread Marco Martin
On Friday 08 August 2014, Eike Hein wrote: > Specifically as far as launchers are concerned, as I mentioned on IRC, > Marco and I have been talking on and off that we could use some sort of > launcher framework to fix all the applet-specific interfaces we have right > now. it is true that would be

Re: Review Request 106448: replace old kickoff with kickoff-qml

2014-08-08 Thread Eike Hein
). This could cause issues for the c++ menu launcher > "simpleapplet"...I'm not using it but actually it doesn't even compile. > Probably would be better to port it to qml as well...opinions? > > The qml code resides in the package dir. It's a pure qml widget

Re: Review Request 106448: replace old kickoff with kickoff-qml

2014-08-08 Thread Eike Hein
> slightly adjusted). This could cause issues for the c++ menu launcher > "simpleapplet"...I'm not using it but actually it doesn't even compile. > Probably would be better to port it to qml as well...opinions? > > The qml code resides in the package dir. It&#x

Re: Review Request 106448: replace old kickoff with kickoff-qml

2014-08-08 Thread Ivan Čukić
quot;...I'm not using it but actually it doesn't even compile. > Probably would be better to port it to qml as well...opinions? > > The qml code resides in the package dir. It's a pure qml widget with c++ > model extensions...obviously :) > > Add to Panel/De

Re: Review Request 106448: replace old kickoff with kickoff-qml

2014-08-08 Thread Ivan Čukić
; > The qml code resides in the package dir. It's a pure qml widget with c++ > model extensions...obviously :) > > Add to Panel/Desktop is still not supported but overall I think we have > reached feature parity with kickoff c++ > > I

Re: Review Request 106448: replace old kickoff with kickoff-qml

2014-08-08 Thread Eike Hein
gt; > The qml code resides in the package dir. It's a pure qml widget with c++ > model extensions...obviously :) > > Add to Panel/Desktop is still not supported but overall I think we have > reached feature parity with kickoff c++ > > I'm also worried about t

Re: Review Request 106448: replace old kickoff with kickoff-qml

2014-08-08 Thread Ivan Čukić
. > Probably would be better to port it to qml as well...opinions? > > The qml code resides in the package dir. It's a pure qml widget with c++ > model extensions...obviously :) > > Add to Panel/Desktop is still not supported but overall I think we have > reached f

Re: Review Request 106448: replace old kickoff with kickoff-qml

2014-08-08 Thread Marco Martin
s still not supported but overall I think we have > reached feature parity with kickoff c++ > > I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How > can we ensure a smooth transition for devs and users? > > > Diffs > - &

Re: Review Request 106448: replace old kickoff with kickoff-qml

2014-07-29 Thread Greg T
ly :) Add to Panel/Desktop is still not supported but overall I think we have reached feature parity with kickoff c++ I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How can we ensure a smooth transition for devs and users? Diffs - plasma/des

Re: Review Request 106448: replace old kickoff with kickoff-qml

2013-02-09 Thread Greg T
here has been made some progress in the last months. Just see the > ml or the repository. > > kickoff-qml still needs some ui polish (tab bar, branding area). help is > always welcome ;) > > Albert Astals Cid wrote: > Not sure what the answer means regarding t

Re: Review Request 106448: replace old kickoff with kickoff-qml

2013-02-09 Thread Albert Astals Cid
here has been made some progress in the last months. Just see the > ml or the repository. > > kickoff-qml still needs some ui polish (tab bar, branding area). help is > always welcome ;) Not sure what the answer means regarding this Review Request. Should we: a) Keep Open as

Re: Review Request 106448: replace old kickoff with kickoff-qml

2013-02-09 Thread Greg T
the last months. Just see the ml or the repository. kickoff-qml still needs some ui polish (tab bar, branding area). help is always welcome ;) - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.re

Re: Review Request 106448: replace old kickoff with kickoff-qml

2013-02-08 Thread Albert Astals Cid
n't even compile. > Probably would be better to port it to qml as well...opinions? > > The qml code resides in the package dir. It's a pure qml widget with c++ > model extensions...obviously :) > > Add to Panel/Desktop is still not supported but overall I think we have >

Re: Kickoff-QML in 4.10 ?

2013-01-09 Thread Sebastian Kügler
On Sunday, January 06, 2013 01:47:06 Aaron J. Seigo wrote: > On Thursday, December 27, 2012 22:36:01 you wrote: > > thanks for the statement. I've addressed most of the points. Of course we > > can't include kickoff-qml into KDE 4.10 anymore, the next target will be >

Re: Kickoff-QML in 4.10 ?

2013-01-05 Thread Aaron J. Seigo
On Thursday, December 27, 2012 22:36:01 you wrote: > thanks for the statement. I've addressed most of the points. Of course we > can't include kickoff-qml into KDE 4.10 anymore, the next target will be > 4.11 then. cool; my suggestion / request is that you merge your

Re: Kickoff-QML in 4.10 ?

2012-12-27 Thread Gregor Tätzner
thanks for the statement. I've addressed most of the points. Of course we can't include kickoff-qml into KDE 4.10 anymore, the next target will be 4.11 then. On Wednesday 14 November 2012 12:50:49 Aaron J. Seigo wrote: > > I tried it again today and there has been some real

Re: Kickoff-QML in 4.10 ?

2012-11-15 Thread Mark
On Wed, Nov 14, 2012 at 12:50 PM, Aaron J. Seigo wrote: > On Tuesday, November 13, 2012 10:08:57 Rick Stockton wrote: >> Beta tagging comes up on Thursday, but I haven't seen any indication >> that Kickoff-QML will be merged into 4.10. > > I tried it again today and

Re: Kickoff-QML in 4.10 ?

2012-11-14 Thread Aaron J. Seigo
On Tuesday, November 13, 2012 10:08:57 Rick Stockton wrote: > Beta tagging comes up on Thursday, but I haven't seen any indication > that Kickoff-QML will be merged into 4.10. I tried it again today and there has been some really good progress, but it is not yet ready for merging.

Kickoff-QML in 4.10 ?

2012-11-13 Thread Rick Stockton
Beta tagging comes up on Thursday, but I haven't seen any indication that Kickoff-QML will be merged into 4.10. Per my concept of "Beta", it seems to have slipped again, yes? If so, then I need to migrate https://git.reviewboard.kde.org/r/106789 forward to 4.10.) Should I also

Re: kickoff qml

2012-11-05 Thread Gregor Tätzner
avy) > > > > i think it should have a minor refactor on how the various pages are > > managed, a qml file for each page (favourites, applications, leave etc) > > and one single contextmenu for each page. > > > > I w

Re: Review Request: Kickoff-qml fixes

2012-11-03 Thread Commit Hook
7ead86e6621de733f590ceff7ee14efa03806e89 by David Edmundson to branch kickoff-qml. - Commit Hook On Oct. 24, 2012, 6:20 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboa

Re: Review Request: Kickoff-qml fixes

2012-11-03 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/#review21387 --- Ship it! If kickoff doesn't fade, kickoff-qml shouldn&#

Re: Review Request: make kickoff-qml partly c++, restores simpleapplet, applet type switch

2012-10-25 Thread Aaron J. Seigo
anymore? > > - also it conflicts with my last commit in kickoff-qml (just a minor in > > kickoff.qml) > > Marco Martin wrote: > yep, 2 desktop files get installed unfortunately, is used in the hybrid > plasmoids, don't see much alternative unfortunately. >

Re: Review Request: Kickoff-qml fixes

2012-10-24 Thread David Edmundson
> On Oct. 24, 2012, 9:16 p.m., Sebastian Kügler wrote: > > plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml, line 109 > > > > > > Why remove this fade in animation? > > David Edmundson wrote: >

Re: Review Request: Kickoff-qml fixes

2012-10-24 Thread David Edmundson
> On Oct. 24, 2012, 9:16 p.m., Sebastian Kügler wrote: > > plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml, line 109 > > > > > > Why remove this fade in animation? Because as one of the other pat

Re: Review Request: Kickoff-qml fixes

2012-10-24 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/#review20823 --- Ship it! One issue (inline), otherwise it looks good. plasma

Review Request: Kickoff-qml fixes

2012-10-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/ --- Review request for Plasma. Description --- If an application has no g

Re: kickoff qml

2012-10-24 Thread David Edmundson
Using bugzilla to track something not in master is not a good idea. It makes it impossible to identify what bugs are actually present in the product being shipped. Which is why I asked :) David ___ Plasma-devel mailing list Plasma-devel@kde.org https://

Re: kickoff qml

2012-10-24 Thread Aaron J. Seigo
On Tuesday, October 23, 2012 21:16:41 David Edmundson wrote: > Marco, where do you want bug reports / tracking what needs to be done. use the normal places: bugs.kde.org, community.kde.org, this mailing list, etc -- Aaron J. Seigo signature.asc Description: This is a digitally signed message pa

Re: kickoff qml

2012-10-23 Thread David Edmundson
s, applications, leave etc) and one single > contextmenu for each page. > > I would like to invite people to test it (kickoff-qml branch) to see if it can > be made good enough in time. > > Cheers, > Marco Martin > ___ > Plasma-d

Re: Kickoff-qml

2012-10-22 Thread Rick Stockton
ter, although my ability to code is so limited that you probably DON'T want me to try any coding. ;) If Kickoff-QML doesn't make it for 4.10, then I'll port my 4.9.3 fix forward to kickoff-widget 4.10. But for now, I'm hoping that Widget-QML takes over. also the code organiz

kickoff qml

2012-10-22 Thread Marco Martin
context menu copy in each delegate that makes things quite heavy) i think it should have a minor refactor on how the various pages are managed, a qml file for each page (favourites, applications, leave etc) and one single contextmenu for each page. I would like to invite people to test it (kickoff-qml

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-21 Thread Greg T
is still not supported but overall I think we have > reached feature parity with kickoff c++ > > I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How > can we ensure a smooth transition for devs and users? > > > Diffs > - > >

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-21 Thread Greg T
top is still not supported but overall I think we have reached feature parity with kickoff c++ I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How can we ensure a smooth transition for devs and users? Diffs (updated) - plasma/des

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-20 Thread Greg T
Gräßlin. Changes --- yay! simpleapplet working again, thanks Marco and kickoff-qml is now a hybrid c++/qml plasmoid Description --- I think it's time now to get the new kickoff into master so we can polish it for KDE 4.10. the qml plasmoid is still using the old model code (t

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-19 Thread Richard Stockton
the package dir. It's a pure qml widget with c++ > model extensions...obviously :) > > Add to Panel/Desktop is still not supported but overall I think we have > reached feature parity with kickoff c++ > > I'm also worried about the upgrade path from kickoff-c++

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-19 Thread Richard Stockton
. It's a pure qml widget with c++ > model extensions...obviously :) > > Add to Panel/Desktop is still not supported but overall I think we have > reached feature parity with kickoff c++ > > I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How >

Re: Review Request: make kickoff-qml partly c++, restores simpleapplet, applet type switch

2012-10-19 Thread Marco Martin
anymore? > > - also it conflicts with my last commit in kickoff-qml (just a minor in > > kickoff.qml) yep, 2 desktop files get installed unfortunately, is used in the hybrid plasmoids, don't see much alternative unfortunately. luckily metadata.desktop is local in the package so

Re: Review Request: make kickoff-qml partly c++, restores simpleapplet, applet type switch

2012-10-19 Thread Greg T
desktop files for the kickoff launcher: - metadata.desktop and the old plasma-applet-launcher.desktop - we don't need CMakeLists.txt in core/ anymore? - also it conflicts with my last commit in kickoff-qml (just a minor in kickoff.qml) - Greg T On Oct. 19, 2012, 1:04 p.m., Marco Martin

Review Request: make kickoff-qml partly c++, restores simpleapplet, applet type switch

2012-10-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106947/ --- Review request for Plasma. Description --- this makes the simple lauc

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-18 Thread Greg T
s...obviously :) Add to Panel/Desktop is still not supported but overall I think we have reached feature parity with kickoff c++ I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How can we ensure a smooth transition for devs and users? Diffs (updated) - plasma/des

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-18 Thread Richard Stockton
esktop is still not supported but overall I think we have > reached feature parity with kickoff c++ > > I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How > can we ensure a smooth transition for devs and users? > >

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-13 Thread Greg T
Add to Panel/Desktop is still not supported but overall I think we have reached feature parity with kickoff c++ I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How can we ensure a smooth transition for devs and users? Diffs (updated) - plasm

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-11 Thread Kai Uwe Broulik
but overall I think we have > reached feature parity with kickoff c++ > > I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How > can we ensure a smooth transition for devs and users? > > > Diffs > ---

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-11 Thread Greg T
ensions...obviously :) Add to Panel/Desktop is still not supported but overall I think we have reached feature parity with kickoff c++ I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How can we ensure a smooth transition for devs and users? Diffs (u

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-06 Thread Greg T
uld cause issues for the c++ menu launcher > "simpleapplet"...I'm not using it but actually it doesn't even compile. > Probably would be better to port it to qml as well...opinions? > > The qml code resides in the package dir. It's a pure qml widget with

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-06 Thread Richard Stockton
It's a pure qml widget with c++ > model extensions...obviously :) > > Add to Panel/Desktop is still not supported but overall I think we have > reached feature parity with kickoff c++ > > I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How >

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-05 Thread Greg T
compile. > Probably would be better to port it to qml as well...opinions? > > The qml code resides in the package dir. It's a pure qml widget with c++ > model extensions...obviously :) > > Add to Panel/Desktop is still not supported but overall I think we have > reached feature

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-05 Thread Marco Martin
lly it doesn't even compile. > Probably would be better to port it to qml as well...opinions? > > The qml code resides in the package dir. It's a pure qml widget with c++ > model extensions...obviously :) > > Add to Panel/Desktop is still not supported but overall I

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-05 Thread Martin Gräßlin
get with c++ > model extensions...obviously :) > > Add to Panel/Desktop is still not supported but overall I think we have > reached feature parity with kickoff c++ > > I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How > can we ensure a smooth

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-05 Thread Greg T
ml widget with c++ > model extensions...obviously :) > > Add to Panel/Desktop is still not supported but overall I think we have > reached feature parity with kickoff c++ > > I'm also worried about the upgrade path from kickoff-c++ to

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-05 Thread Marco Martin
gt; > The qml code resides in the package dir. It's a pure qml widget with c++ > model extensions...obviously :) > > Add to Panel/Desktop is still not supported but overall I think we have > reached feature parity with kickoff c++ > > I'm also worried about the u

Re: Review Request: replace old kickoff with kickoff-qml

2012-09-20 Thread Greg T
++ model extensions...obviously :) Add to Panel/Desktop is still not supported but overall I think we have reached feature parity with kickoff c++ I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How can we ensure a smooth transition for devs and users?

Re: Review Request: replace old kickoff with kickoff-qml

2012-09-19 Thread Martin Gräßlin
better to port it to qml as well...opinions? > > The qml code resides in the package dir. It's a pure qml widget with c++ > model extensions...obviously :) > > Add to Panel/Desktop is still not supported but overall I think we have > reached feature parity with kickoff c++ &

Re: *** GMX Spamverdacht *** Re: Review Request: replace old kickoff with kickoff-qml

2012-09-16 Thread Marco Martin
On Sunday 16 September 2012, Daniel Nicoletti wrote: > Hmm, well I thought you had a dataengine for the applications model, > so uninstall, favorite, sort would all be exposed as services, but it > seems it's not the case, sure it makes sence since from my experience > dataengines are slow with a g

Re: *** GMX Spamverdacht *** Re: Review Request: replace old kickoff with kickoff-qml

2012-09-16 Thread Daniel Nicoletti
Hmm, well I thought you had a dataengine for the applications model, so uninstall, favorite, sort would all be exposed as services, but it seems it's not the case, sure it makes sence since from my experience dataengines are slow with a good amount of data. Anyway I just tought having a dataengine

Re: *** GMX Spamverdacht *** Re: Review Request: replace old kickoff with kickoff-qml

2012-09-16 Thread Marco Martin
On Sunday 16 September 2012, Gregor Tätzner wrote: > You mean all of them? We have planned to create a dataengine for adding > launcher items to the panel but why would you want to expose a 'Sort menu > from A-Z'? It's strongly tied to the kickoff model. yes, stuff like sorting should be just inte

Re: *** GMX Spamverdacht *** Re: Review Request: replace old kickoff with kickoff-qml

2012-09-15 Thread Gregor Tätzner
extensions...obviously :) > > > > Add to Panel/Desktop is still not supported but overall I think we have > > reached feature parity with kickoff c++ > > > > I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. > > How can we ens

Re: Review Request: replace old kickoff with kickoff-qml

2012-09-15 Thread Daniel Nicoletti
doesn't even compile. > Probably would be better to port it to qml as well...opinions? > > The qml code resides in the package dir. It's a pure qml widget with c++ > model extensions...obviously :) > > Add to Panel/Desktop is still not supported but overall I think we have

Re: Review Request: replace old kickoff with kickoff-qml

2012-09-15 Thread Greg T
n the package dir. It's a pure qml widget with c++ model extensions...obviously :) Add to Panel/Desktop is still not supported but overall I think we have reached feature parity with kickoff c++ I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How can we ensu

Re: Review Request: replace old kickoff with kickoff-qml

2012-09-15 Thread Daniel Nicoletti
sly :) > > Add to Panel/Desktop is still not supported but overall I think we have > reached feature parity with kickoff c++ > > I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How > can we ensure a smooth transition for devs and users? > >

Re: Review Request: replace old kickoff with kickoff-qml

2012-09-15 Thread Greg T
ml as well...opinions? > > The qml code resides in the package dir. It's a pure qml widget with c++ > model extensions...obviously :) > > Add to Panel/Desktop is still not supported but overall I think we have > reached feature parity with kick

Review Request: replace old kickoff with kickoff-qml

2012-09-14 Thread Greg T
ff c++ I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How can we ensure a smooth transition for devs and users? Diffs - ksplash/ksplashqml/SplashWindow.cpp 94e6dedfddcac20516686a7a3b30651d48bc26e7 plasma/desktop/applets/kickoff/CMakeLists.txt 4b0d3

Re: Review Request: kickoff-qml: TabBar button width

2012-07-26 Thread Marco Martin
> On July 19, 2012, 9:04 a.m., Marco Martin wrote: > > thanks, wouldn;t have remembered ;) > > > > the changes seems good, but i'm not sure about giving kickoff a copy of the > > tabbar. > > > > any reason this is not proposed as a patch for the tabbar component itself? > > Greg T wrote: >

Re: Review Request: kickoff-qml: TabBar button width

2012-07-20 Thread Greg T
> On July 19, 2012, 9:04 a.m., Marco Martin wrote: > > thanks, wouldn;t have remembered ;) > > > > the changes seems good, but i'm not sure about giving kickoff a copy of the > > tabbar. > > > > any reason this is not proposed as a patch for the tabbar component itself? > > Greg T wrote: >

Re: Review Request: kickoff-qml: TabBar button width

2012-07-19 Thread Marco Martin
> On July 19, 2012, 9:04 a.m., Marco Martin wrote: > > thanks, wouldn;t have remembered ;) > > > > the changes seems good, but i'm not sure about giving kickoff a copy of the > > tabbar. > > > > any reason this is not proposed as a patch for the tabbar component itself? > > Greg T wrote: >

Re: Review Request: kickoff-qml: TabBar button width

2012-07-19 Thread Greg T
> On July 19, 2012, 9:04 a.m., Marco Martin wrote: > > thanks, wouldn;t have remembered ;) > > > > the changes seems good, but i'm not sure about giving kickoff a copy of the > > tabbar. > > > > any reason this is not proposed as a patch for the tabbar component itself? Of course I could do t

Re: Review Request: kickoff-qml: TabBar button width

2012-07-19 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105405/#review16118 --- If you ask me, i like the "old" view better with the elided tex

Re: Review Request: kickoff-qml: TabBar button width

2012-07-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105405/#review16103 --- thanks, wouldn;t have remembered ;) the changes seems good, bu

Re: Review Request: kickoff-qml: TabBar button width

2012-07-19 Thread Greg T
> On July 3, 2012, 8:34 a.m., Martin Gräßlin wrote: > > please push it again after Akademy - I doubt that I find the time to > > properly read through it in this week well *push* :) any ideas? - Greg --- This is an automatically genera

Re: Review Request: kickoff-qml: TabBar button width

2012-07-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105405/#review15332 --- please push it again after Akademy - I doubt that I find the ti

Review Request: kickoff-qml: TabBar button width

2012-07-01 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105405/ --- Review request for Plasma, Marco Martin and Martin Gräßlin. Description --

Re: Review Request: improve/add keyboard navigation in kickoff-qml (mystery included)

2012-06-18 Thread Greg T
> On June 10, 2012, 7:56 a.m., Martin Gräßlin wrote: > > cool, thanks for taking up where I left the work. I appreciate that very > > much. > > > > I have no idea about the key handling issue. I will try to test out the > > branch next week and play with it. > > > > As everything is in a bran

Re: Review Request: improve/add keyboard navigation in kickoff-qml (mystery included)

2012-06-11 Thread Commit Hook
7455a4e22bc9142a62d4fe96592b361260f4c725 by Gregor Tätzner to branch kickoff-qml. - Commit Hook On June 9, 2012, 12:32 p.m., Greg T wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: improve/add keyboard navigation in kickoff-qml (mystery included)

2012-06-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105196/#review14571 --- Ship it! cool, thanks for taking up where I left the work. I a

Review Request: improve/add keyboard navigation in kickoff-qml (mystery included)

2012-06-09 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105196/ --- Review request for Plasma and Martin Gräßlin. Description --- since q

Re: Kickoff-QML and classic launcher

2011-12-31 Thread Marco Martin
On Saturday 31 December 2011, Aaron J. Seigo wrote: > that assumption seems weak and i have not seen evidence to back it. > > yes, people who like the classic menu are loud and provide feedback. > however, it's usually of the overly aggressive "get off my lawn!" type and > that leads me to believe

Re: Kickoff-QML and classic launcher

2011-12-31 Thread Aaron J. Seigo
On Saturday, December 24, 2011 03:29:19 Kevin Kofler wrote: > Aaron J. Seigo wrote: > > it's really a horrible hack and i'd suggest getting rid of it. people can > > add the classic menu from the widget explorer like all the rest. > > This is just going to make it much harder to switch to a menu p

Re: Kickoff-QML and classic launcher

2011-12-31 Thread Aaron J. Seigo
On Saturday, December 24, 2011 03:21:07 Kevin Kofler wrote: > Martin Graesslin wrote: > > * Would it be acceptable to drop the classic menu completely? This > > would be more consistent with the general concept of having only one > > applet per area. Optionally the classic menu could be re-added in

Re: Kickoff-QML and classic launcher

2011-12-23 Thread Shaun Reich
On Fri, Dec 23, 2011 at 9:29 PM, Kevin Kofler wrote: > Aaron J. Seigo wrote: >> it's really a horrible hack and i'd suggest getting rid of it. people can >> add the classic menu from the widget explorer like all the rest. > > This is just going to make it much harder to switch to a menu people lik

Re: Kickoff-QML and classic launcher

2011-12-23 Thread Kevin Kofler
Aaron J. Seigo wrote: > it's really a horrible hack and i'd suggest getting rid of it. people can > add the classic menu from the widget explorer like all the rest. This is just going to make it much harder to switch to a menu people like me can actually use. :-( Especially for people switching t

Re: Kickoff-QML and classic launcher

2011-12-23 Thread Kevin Kofler
Martin Graesslin wrote: > * Would it be acceptable to drop the classic menu completely? This > would be more consistent with the general concept of having only one > applet per area. Optionally the classic menu could be re-added in > Plasma-Addons just like Lancelot. You can pry my classic menu fr

Re: Kickoff-QML and classic launcher

2011-12-22 Thread Nowardev-Team
2011/12/23 Markus Slopianka > On Donnerstag 22 Dezember 2011 12:54:37 Nowardev-Team wrote: > > > > sure i have not problem but how :D right now i have done kde3 panel :P > > Please don't call it that way. It should be referred to as Classic panel > or something like > that to be in line with curr

Re: Kickoff-QML and classic launcher

2011-12-22 Thread Markus Slopianka
On Donnerstag 22 Dezember 2011 12:54:37 Nowardev-Team wrote: > > sure i have not problem but how :D right now i have done kde3 panel :P Please don't call it that way. It should be referred to as Classic panel or something like that to be in line with current wording. ___

Re: Kickoff-QML and classic launcher

2011-12-22 Thread Aaron J. Seigo
On Thursday, December 22, 2011 12:54:37 Nowardev-Team wrote: > sure i have not problem but how :D right now i have done kde3 panel :P well, what we'd do is set you up with a commit account: http://techbase.kde.org/Contribute/Get_a_Contributor_Account then you could make a subdirectory in

Re: Kickoff-QML and classic launcher

2011-12-22 Thread Nowardev-Team
2011/12/22 Aaron J. Seigo > On Thursday, December 22, 2011 10:58:41 Nowardev-Team wrote: > > layout right now, > > > > svn export --force > > > https://plasma-panels-script.googlecode.com/svn/trunk/usr/share/kde4/apps/pl > > asma/layout-templates/ > > ok. craaaAAAaazy idea time! well, not re

Re: Kickoff-QML and classic launcher

2011-12-22 Thread Aaron J. Seigo
On Thursday, December 22, 2011 10:58:41 Nowardev-Team wrote: > layout right now, > > svn export --force > https://plasma-panels-script.googlecode.com/svn/trunk/usr/share/kde4/apps/pl > asma/layout-templates/ ok. craaaAAAaazy idea time! well, not really, but it sounds more fun that way. ;)

Re: Re: Kickoff-QML and classic launcher

2011-12-22 Thread Martin Gräßlin
On Thursday 22 December 2011 11:32:20 Nowardev-Team wrote: > http://kde-apps.org/content/show.php/Plasma+Panels+Collection+?content=14758 > 9 http://www.youtube.com/watch?v=o_qR-7FQHxc very nice :-) signature.asc Description: This is a digitally signed message part. ___

Re: Kickoff-QML and classic launcher

2011-12-22 Thread Nowardev-Team
2011/12/22 Marco Martin > On Thursday 22 December 2011, Nowardev-Team wrote: > > > : > > :) i did a lots of panels btw.. mm i could try to make classic kde3 > > > > layout right now, > > > > svn export --force > > > https://plasma-panels-script.googlecode.com/svn/trunk/usr/share/kde4/apps/p >

Re: Kickoff-QML and classic launcher

2011-12-22 Thread Marco Martin
On Thursday 22 December 2011, Nowardev-Team wrote: > : > :) i did a lots of panels btw.. mm i could try to make classic kde3 > > layout right now, > > svn export --force > https://plasma-panels-script.googlecode.com/svn/trunk/usr/share/kde4/apps/p > lasma/layout-templates/ cool :D so the op

Re: Re: Kickoff-QML and classic launcher

2011-12-22 Thread Nowardev-Team
2011/12/22 Martin Gräßlin > On Wednesday 21 December 2011 18:25:51 Aaron J. Seigo wrote: > > On Tuesday, December 20, 2011 20:51:32 Martin Graesslin wrote: > > > My personal favorite is option 3. > > > > 3 is a good solution imho ... except that it will break people's > > installations who have k

  1   2   >