> On Oct. 19, 2012, 3:09 p.m., Greg T wrote: > > looks good, just a couple of notes: > > why are you installing 2 desktop files for the kickoff launcher: > > - metadata.desktop and the old plasma-applet-launcher.desktop > > - we don't need CMakeLists.txt in core/ anymore? > > - also it conflicts with my last commit in kickoff-qml (just a minor in > > kickoff.qml)
yep, 2 desktop files get installed unfortunately, is used in the hybrid plasmoids, don't see much alternative unfortunately. luckily metadata.desktop is local in the package so doesn't go to pollute the syscoca db i resolved the conflict and removed the other files besides cmakefile in core (pretty much all of ui/ and the config stuff in the package) - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106947/#review20575 ----------------------------------------------------------- On Oct. 19, 2012, 1:04 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106947/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2012, 1:04 p.m.) > > > Review request for Plasma. > > > Description > ------- > > this makes the simple laucher work again, and since kickoff is in part c++, > the menu editor option as well as the switch from kickoff to classic works > again. > > main reason of this tough is to eliminate the org.kde.kickoff import, that > shouldn't be public api > > > Diffs > ----- > > plasma/desktop/applets/kickoff/CMakeLists.txt 4f61700 > plasma/desktop/applets/kickoff/applet/applet.h f3afe73 > plasma/desktop/applets/kickoff/applet/applet.cpp a6f7379 > plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml 4d0e218 > plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml f953565 > plasma/desktop/applets/kickoff/package/metadata.desktop 9cb997d > plasma/desktop/applets/kickoff/simpleapplet/menuview.cpp 963c18b > plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp 28fba18 > > Diff: http://git.reviewboard.kde.org/r/106947/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
