hein added a comment.
Fixed in
https://commits.kde.org/plasma-desktop/9dfc225ece2758e1b93a4c818e5559ede12a5d72
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9152
To: hein, #plasma, mart, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, ZrenBot, pro
hein added a comment.
Ooops, fixing.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9152
To: hein, #plasma, mart, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
broulik added inline comments.
INLINE COMMENTS
> main.qml:282
>
> -property int oldX: x
> -property int oldY: y
> +readonly property int oldX: x
> +readonly property int oldY: y
This property is being assigned to, it cannot be `readonly`.
> main
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:194483b05a75: Save an object per panel applet (authored
by hein).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9152?vs=23381&id=23386#toc
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST
hein added a comment.
Will add a comment, the sizing thing isn't a problem because the Loader
resizes the BusyIndicator.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9152
To: hein, #plasma, mart, davidedmundson
Cc: davidedmundson, plasma-d
mart accepted this revision.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9152
To: hein, #plasma, mart, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9152
To: hein, #plasma, mart, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,
davidedmundson added a comment.
In general +1.
A comment at the top of Loader making it clear it's not a loader for the
applet would help.
INLINE COMMENTS
> main.qml:292
> +active: applet && applet.busy
> +sourceComponent: PlasmaComponents.BusyIndicator {}
> +
In t
hein created this revision.
hein added reviewers: Plasma, mart.
Restricted Application added a project: Plasma.
REVISION SUMMARY
Instead of Item { Loader {} } just make the applet
container the Loader. Also saves some prop bindings
for sizing and centering the BusyIndicator, which
still ap
