davidedmundson added a comment.
This got stuck because of some big kicker rewrite that happened in the
meantime (and there's still some more on phab).
I'll abandon this then re-upload in smaller bite size chunks
REPOSITORY
R119 Plasma Desktop
BRANCH
backup
REVISION DETAIL
https:/
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
ok from me and yes, better to wait right after 5.11
REPOSITORY
R119 Plasma Desktop
BRANCH
backup
REVISION DETAIL
https://phabricator.kde.org/D7780
To: davidedmundson, #plasma, mart
Cc:
davidedmundson updated this revision to Diff 19461.
davidedmundson added a comment.
In the old code sometimes the root item would mostly have focus,
sometimes the relevant object. The root item would then perform key
handling for everyone and dispatch events to the relevant place
davidedmundson planned changes to this revision.
davidedmundson added inline comments.
INLINE COMMENTS
> ApplicationsView.qml:26
>
> -Item {
> +FocusScope {
> id: appViewContainer
Edit:
I did this because FullScreenRep was setting focus on this item explicitly.
but given that was rubbish
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
FocusProxy is added to all the Baseviews as an effective focus proxy to
forward focus to the contained Scrollview which in turn forwar