davidedmundson updated this revision to Diff 19461.
davidedmundson added a comment.
In the old code sometimes the root item would mostly have focus,
sometimes the relevant object. The root item would then perform key
handling for everyone and dispatch events to the relevant place.
Because focus kept ending up in the wrong place and faked, this broke
accessibility (as well as being quite messy).
In the new code items all handle their own key handling. Anything
unhandled propagates to the root view which then Keys.forwardTo the
relevant items.
Behaviour is mostly identical (except I changed escape in the
Applications view)
Change is too massive for 5.11, will delay for master.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7780?vs=19436&id=19461
BRANCH
backup
REVISION DETAIL
https://phabricator.kde.org/D7780
AFFECTED FILES
applets/kickoff/package/contents/ui/ApplicationsView.qml
applets/kickoff/package/contents/ui/BaseView.qml
applets/kickoff/package/contents/ui/ComputerView.qml
applets/kickoff/package/contents/ui/FavoritesView.qml
applets/kickoff/package/contents/ui/FullRepresentation.qml
applets/kickoff/package/contents/ui/Header.qml
applets/kickoff/package/contents/ui/KickoffItem.qml
applets/kickoff/package/contents/ui/LeaveView.qml
applets/kickoff/package/contents/ui/OftenUsedView.qml
applets/kickoff/package/contents/ui/RecentlyUsedView.qml
applets/kickoff/package/contents/ui/SearchView.qml
To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
