D6917: [Component Chooser] Add ComboBox with browsers

2017-07-26 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:4cd9302762c6: [Component Chooser] Add ComboBox with browsers (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6917?vs=17215&id=17235#toc REPOSITORY R119 Plasma Desktop

D6917: [Component Chooser] Add ComboBox with browsers

2017-07-26 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Excellent idea. INLINE COMMENTS > broulik wrote in componentchooserbrowser.cpp:85 > One could also instead use > > KServiceTypeTrader::self()->query(QStringLiteral("Application"), > QSt

D6917: [Component Chooser] Add ComboBox with browsers

2017-07-26 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > componentchooserbrowser.cpp:85 > + > +const auto &browsers = > KMimeTypeTrader::self()->query(QStringLiteral("text/html"), > QStringLiteral("Application"));; > +for (const auto &service : browsers) { One could also instead use KServic

D6917: [Component Chooser] Add ComboBox with browsers

2017-07-26 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This makes the dialog more user-friendly by providing a ComboBox with applications that can handle text/html (typically web browsers) instead