broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY This makes the dialog more user-friendly by providing a ComboBox with applications that can handle text/html (typically web browsers) instead of only providing a "guess contents" and "custom command" text field. TEST PLAN Before F3820514: Screenshot_20170726_115838.png <https://phabricator.kde.org/F3820514> After F3820515: Screenshot_20170726_115921.png <https://phabricator.kde.org/F3820515> Verified that: - Checking "in an application based on contents" removes the BrowserApplication from kdeglobals - Selecting an application from the combo is properly saved and restored - Entering a custom command is properly saved and restored - When choosing a custom application (`...` button) but it is listed in the combobox, the "in the following application" is checked and the appropriate entry in the ComboBox selected - clicking links in KDE apps actually open in the desired application REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6917 AFFECTED FILES kcms/componentchooser/browserconfig_ui.ui kcms/componentchooser/componentchooserbrowser.cpp To: broulik, #plasma, #vdg, dfaure Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
