This revision was automatically updated to reflect the committed changes.
Closed by commit R108:fe231be5e2d4: Keep all touchpad QActions in the main
thread (authored by davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5733?vs=14219&id=14228
REVISI
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5733
To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff,
lesliezhai
davidedmundson updated this revision to Diff 14219.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Split to new function
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5733?vs=14215&id=14219
BRANCH
master
graesslin added inline comments.
INLINE COMMENTS
> input.cpp:1759
> + // steal touchpad shortcuts
> +QAction *touchpadToggleAction = new QAction(this);
> +QAction *touchpadOnAction = new QAction(this);
I think this should be in the if (con) branch.
Given that the method is already q
davidedmundson created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REVISION SUMMARY
Making QActions with the Connection as a parent is dangerous as it gets
moved to a new thread, moving all child objects to th
