D5429: Add option to focus some widgets only on keyboard input

2017-04-13 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. For comboxes at least, once focused (mouse or keyboard), when you press up and down arrows, they change selection. So focus should be there I think For buttons, same thing. You have a button group, focus on one button (mouse or keyboard), then press the arro

D5429: Add option to focus some widgets only on keyboard input

2017-04-13 Thread Eike Hein
hein added a comment. Why do buttons and comboboxes need the focus indicator on click (vs. keyboard) more than checkboxes and tabs, though? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D5429 To: mart, #plasma, hpereiradacosta Cc: hein, colomar, plasma-devel, progwol

D5429: Add option to focus some widgets only on keyboard input

2017-04-13 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D5429#101848, @hpereiradacosta wrote: > In https://phabricator.kde.org/D5429#101847, @colomar wrote: > > > It definitely should not be an option. Either it's better, then it goes in, or it isn't, then it doesn't. > > > Agreed.

D5429: Add option to focus some widgets only on keyboard input

2017-04-13 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. In https://phabricator.kde.org/D5429#101847, @colomar wrote: > It definitely should not be an option. Either it's better, then it goes in, or it isn't, then it doesn't. Agreed. If indeed it fixes bugs and inconsistencies (rather than introduces

D5429: Add option to focus some widgets only on keyboard input

2017-04-13 Thread Thomas Pfeiffer
colomar added a comment. It definitely should not be an option. Either it's better, then it goes in, or it isn't, then it doesn't. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D5429 To: mart, #plasma, hpereiradacosta Cc: hein, colomar, plasma-devel, progwolff, lesli

D5429: Add option to focus some widgets only on keyboard input

2017-04-13 Thread Eike Hein
hein added a comment. There's no tickets. This change is the result of a QA session over at Netrunner where we noticed the following behavior pattern for the tab bar widget: 1. If you just click a tab, there is usually no focus indicator line shown 2. If you use the Tab key to reach a

D5429: Add option to focus some widgets only on keyboard input

2017-04-13 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. @Marco, could you detail which widgets have their mouse focus disabled ? as there some bug reports wishlist about the issue you mention ? Honestly I would argue that the disabled feature are all design choices and should not be worth an option for disab

D5429: Add option to focus some widgets only on keyboard input

2017-04-13 Thread Thomas Pfeiffer
colomar added a comment. Who has complained about this? Can we see the reports? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D5429 To: mart, #plasma, hpereiradacosta Cc: colomar, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5429: Add option to focus some widgets only on keyboard input

2017-04-13 Thread Marco Martin
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Due some complaints about visual clutterness of things like buttons changing color when clicked, or checkboxes getting their label underlined,