D5061: [sddm-theme] Add virtual keyboard support

2017-03-26 Thread Martin Gräßlin
graesslin added a comment. > FYI, if you want to check via SDDM > sddm-greeter --test-mode --theme /opt/kde5/share/sddm/themes/breeze/ That one I had tried with the env variable and it worked fine. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/

D5061: [sddm-theme] Add virtual keyboard support

2017-03-26 Thread David Edmundson
davidedmundson added a comment. Bah. Thanks for investigating. Ah well, you didn't expect it work OOTB anyway...so it's no worse, and I can get this into 0.14.1 rather than it being a new feature. Upstream request. https://github.com/sddm/sddm/pull/803 FYI, if you want to check vi

D5061: [sddm-theme] Add virtual keyboard support

2017-03-26 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R120:78d2c9ffbed6: [sddm-theme] Add virtual keyboard support (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5061?vs=12503&id=12825#toc REPOSITORY R120 Plasma Workspace C

D5061: [sddm-theme] Add virtual keyboard support

2017-03-26 Thread Martin Gräßlin
graesslin added a comment. I'm going to push nevertheless. A little bit sad, that it doesn't work OOTB, but well... INLINE COMMENTS > davidedmundson wrote in Main.qml:174 > I don't get what this property is all about? > > Does Qt.inputMethod.visible start off true, and you're effectively ma

D5061: [sddm-theme] Add virtual keyboard support

2017-03-26 Thread Martin Gräßlin
graesslin added a comment. yep, does not work: sddm/src/daemon/greeter.cpp - setting QT_IM_MODULE is only done in the branch if (daemonApp->testing()) REPOSITORY R120 Plasma Workspace BRANCH sddm-them-virtualkeyboard REVISION DETAIL https://phabricator.kde.org/D5061 To: graesslin, #p

D5061: [sddm-theme] Add virtual keyboard support

2017-03-26 Thread Martin Gräßlin
graesslin added a comment. and just for reference: sddm --example-config [Autologin] # Whether sddm should automatically log back into sessions when they exit Relogin=false # Name of session file for autologin session (if empty try last logged in) Session=

D5061: [sddm-theme] Add virtual keyboard support

2017-03-26 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D5061#96641, @davidedmundson wrote: > FYI, SDDM requires only a config change. We added support a while back. are you sure that works? I added the config and QT_IM_MODULE is not getting added to the environment of sddm-gree

D5061: [sddm-theme] Add virtual keyboard support

2017-03-22 Thread Martin Gräßlin
graesslin added a comment. > It's worth testing natively as opposed to qmlscene because components loading can be a bit weird because of paths. will do! Wasn't aware that it's possible to use qtvirtualkeyboard already. That was the missing piece for testing. REPOSITORY R120 Plasma Wor

D5061: [sddm-theme] Add virtual keyboard support

2017-03-22 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. FYI, SDDM requires only a config change. We added support a while back. It's worth testing natively as opposed to qmlscene because components loading can be a bit weird

D5061: [sddm-theme] Add virtual keyboard support

2017-03-16 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > mart wrote in Main.qml:126 > they shouldn't show/hide themselves depending to the keyboard. > the keyboard should just slide over them and cover them if necessary It looked really bad, that's why I went for hiding them. Somehow on the lock scre

D5061: [sddm-theme] Add virtual keyboard support

2017-03-16 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > Main.qml:126 > +enabled: sddm.canSuspend > +visible: !inputPanel.keyboardActive > +}, they shouldn't show/hide themselves depending to the keyboard. the keyboard should just slide ov

D5061: [sddm-theme] Add virtual keyboard support

2017-03-15 Thread Martin Gräßlin
graesslin marked an inline comment as done. graesslin added inline comments. INLINE COMMENTS > broulik wrote in LockScreenUi.qml:202 > Just set the source directly? > > Alternatively, set the source directly alongside `active: false` and then set > active true manually As that is in unrelated

D5061: [sddm-theme] Add virtual keyboard support

2017-03-15 Thread Martin Gräßlin
graesslin updated this revision to Diff 12503. graesslin added a comment. Addressed Kai-Uwe's suggestions REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5061?vs=12498&id=12503 BRANCH sddm-them-virtualkeyboard REVISION DETAIL https://phabricat

D5061: [sddm-theme] Add virtual keyboard support

2017-03-15 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > LockScreenUi.qml:202 > } > -Component.onCompleted: inputPanel.source = > "VirtualKeyboard.qml" > +Component.onCompleted: inputPanel.source = > "../components/VirtualKeyboard.qml" > }

D5061: [sddm-theme] Add virtual keyboard support

2017-03-15 Thread Martin Gräßlin
graesslin added a comment. F2851755: sddm-them-virtual-keyboard.png - note the overlap with the clock will hardly be a problem in reality. It suffers from the same problem as the lockscreen, will upload a patch for it. REPOSITORY R120 Plasma Workspac

D5061: [sddm-theme] Add virtual keyboard support

2017-03-15 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Just like in the lock screen this adds support for virtual keyboard. Note: this requires adjustments in sddm, the greeter must specify the