broulik added inline comments.

INLINE COMMENTS

> LockScreenUi.qml:202
>                  }
> -                Component.onCompleted: inputPanel.source = 
> "VirtualKeyboard.qml"
> +                Component.onCompleted: inputPanel.source = 
> "../components/VirtualKeyboard.qml"
>              }

Just set the source directly?

Alternatively, set the source directly alongside `active: false` and then set 
active true manually

> Main.qml:168
> +            Layout.fillWidth: true
> +            Layout.preferredHeight: item ? (item.active ? 
> item.implicitHeight : 0) : 0
> +            function showHide() {

`item && item.active ? item.implicitHeight : 0`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5061

To: graesslin, #plasma
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

Reply via email to