mart closed this revision.
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D28922
To: mart, #plasma, ahiemstra, #vdg
Cc: zzag, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliez
mart updated this revision to Diff 82289.
mart added a comment.
- Merge branch 'sensors_lib' into mart/sensor_face
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28922?vs=82279&id=82289
BRANCH
mart/sensor_face
REVISION DETAIL
https://phabric
mart updated this revision to Diff 82279.
mart added a comment.
- sensorColors is now a map
- fix preset uninstall
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28922?vs=82223&id=82279
BRANCH
mart/sensor_face
REVISION DETAIL
https://phabr
zzag added inline comments.
INLINE COMMENTS
> SensorFaceController.cpp:177
> +if (component->status() != QQmlComponent::Ready) {
> +qCritical() << "Error creating component:";
> +for (auto err : component->errors()) {
One could argue that "Error creating component" is a prett
ngraham added a comment.
Hmm, this doesn't seem to apply cleanly on top of current master.
REPOSITORY
R111 KSysguard Library
BRANCH
mart/sensor_face
REVISION DETAIL
https://phabricator.kde.org/D28922
To: mart, #plasma, ahiemstra, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-F
mart updated this revision to Diff 82223.
mart added a comment.
- use QJsonArrays for sensors
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28922?vs=82188&id=82223
BRANCH
mart/sensor_face
REVISION DETAIL
https://phabricator.kde.org/D28922
mart updated this revision to Diff 82188.
mart added a comment.
- remove extra debug
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28922?vs=82185&id=82188
BRANCH
mart/sensor_face
REVISION DETAIL
https://phabricator.kde.org/D28922
AFFECTED
mart updated this revision to Diff 82185.
mart added a comment.
- use regexp for multiple sensors
- left-alignlegends when they are too wide
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28922?vs=82119&id=82185
BRANCH
mart/sensor_face
REVIS
mart updated this revision to Diff 82119.
mart marked 5 inline comments as done.
mart added a comment.
- add space
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28922?vs=82116&id=82119
BRANCH
mart/sensor_face
REVISION DETAIL
https://phabric
mart updated this revision to Diff 82116.
mart added a comment.
- move face properties in own file
- move face config in own file
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28922?vs=82089&id=82116
BRANCH
mart/sensor_face
REVISION DETAIL
ahiemstra accepted this revision.
ahiemstra added a comment.
This revision is now accepted and ready to land.
Let's get this in and fix anything broken in follow ups.
REPOSITORY
R111 KSysguard Library
BRANCH
mart/sensor_face
REVISION DETAIL
https://phabricator.kde.org/D28922
To: mart,
mart updated this revision to Diff 82089.
mart added a comment.
- default to linechart
- default to textonly
- sensorIds highPrioritySensorIds
- kill table visualization
- TotalSensor->TotalSensors list
- SupportsTotalSensor->SupportsTotalSensors
REPOSITORY
R111 KSysguard Library
ahiemstra added inline comments.
INLINE COMMENTS
> mart wrote in SensorFaceController.h:47
> how would that work in current faces that have this binded to that single big
> number inside graphs?
You'd use the first one from the list? If we want to limit it I think we need
to limit it in the UI
ngraham added inline comments.
INLINE COMMENTS
> ConfigAppearance.qml:24
> +import QtQuick.Layouts 1.2
> +import QtQuick.Controls 2.2 as Controls
> +
`as QQC2`
> ConfigAppearance.qml:69
> +delegate: Kirigami.SwipeListItem {
> +contentItem: Controls.Label {
> +
mart added inline comments.
INLINE COMMENTS
> ahiemstra wrote in SensorFaceController.h:47
> I think it would be a good idea to make this a list of ids as well. My
> current use case would be the "used/total" version of the pie chart that is
> used in KSysGuardQML, which would need two "total"
ahiemstra added inline comments.
INLINE COMMENTS
> mart wrote in SensorFaceController.cpp:247
> perhaps line chart?
I was more thinking something along the lines of a new face that's either
completely empty or displays a "not configured" message.
REPOSITORY
R111 KSysguard Library
REVISION D
mart added inline comments.
INLINE COMMENTS
> ahiemstra wrote in SensorFaceController.cpp:77
> Similar to above, does it still make sense to use "Plasma/Applet" here?
it kinda has to, as the original idea is to be able to use any preset as it was
a standalone applet, so creating a preset means
mart updated this revision to Diff 81882.
mart marked 7 inline comments as done.
mart added a comment.
- start to port other faces
- port faces to new api
- add missing file
- adapt to api changes
- adress a part of comments
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDAT
ahiemstra added inline comments.
INLINE COMMENTS
> ConfigAppearance.qml:90
> +}
> +RowLayout {
> +Kirigami.FormData.label: i18n("Presets:")
It would probably be nice if we can make this a GridLayout with flow bound to
the FormLayout's wide setting. Right now, if the layout becom
ahiemstra added inline comments.
INLINE COMMENTS
> SensorFaceController.h:42
> +
> +class FACES_EXPORT SensorFaceController : public QObject
> +{
Can you place this class (and related classes) in the KSysGuard namespace? Then
it would match the rest of the libraries.
REPOSITORY
R111 KSysguar
ahiemstra added inline comments.
INLINE COMMENTS
> CMakeLists.txt:52
> KF5::I18n
> +KF5::Package
> +KF5::ConfigCore
This is no longer needed.
> CMakeLists.txt:5
>
> -target_link_libraries(SensorsPlugin Qt5::Qml KSysGuard::Sensors
> KF5::ProcessCore)
> +target_link_li
mart updated this revision to Diff 81078.
mart added a comment.
- move here faces and packagestructure
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28922?vs=81019&id=81078
BRANCH
mart/sensor_face
REVISION DETAIL
https://phabricator.kde.org
mart updated this revision to Diff 81019.
mart added a comment.
- move all face-related stuff in own library
- use the new face library
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28922?vs=80982&id=81019
BRANCH
mart/sensor_face
REVISION D
mart updated this revision to Diff 80982.
mart added a comment.
- add missing file
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28922?vs=80401&id=80982
BRANCH
mart/sensor_face
REVISION DETAIL
https://phabricator.kde.org/D28922
AFFECTED FI
ahiemstra added inline comments.
INLINE COMMENTS
> SensorFaceController.cpp:21
> +#include "SensorFaceController.h"
> +#include "SensorFaceController_p.h"
> +#include "SensorFace_p.h"
This file is missing.
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D28922
mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.
REVISION SUMMARY
The plasmoid loginc has been ported in the SensorFaceController public class
it's its responsibility to i
26 matches
Mail list logo
