zzag added inline comments.

INLINE COMMENTS

> SensorFaceController.cpp:177
> +    if (component->status() != QQmlComponent::Ready) {
> +        qCritical() << "Error creating component:";
> +        for (auto err : component->errors()) {

One could argue that "Error creating component" is a pretty common error 
message. Categorized logging can be useful for resolving such ambiguities.

REPOSITORY
  R111 KSysguard Library

BRANCH
  mart/sensor_face

REVISION DETAIL
  https://phabricator.kde.org/D28922

To: mart, #plasma, ahiemstra, #vdg
Cc: zzag, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to