This revision was automatically updated to reflect the committed changes.
Closed by commit R106:75333fc13159: Add a new daemon for stats monitoring
(authored by davidedmundson).
REPOSITORY
R106 KSysguard
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28333?vs=81871&id=82105
REVISION
ahiemstra accepted this revision.
ahiemstra added a comment.
Let's do this.
REPOSITORY
R106 KSysguard
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28333
To: davidedmundson, #plasma, mart, ngraham, ahiemstra
Cc: ahiemstra, ivan, mart, zzag, plasma-devel, Orage, LeGast00n,
davidedmundson updated this revision to Diff 81871.
davidedmundson marked an inline comment as done.
davidedmundson added a comment.
Clear up plugin loading
REPOSITORY
R106 KSysguard
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28333?vs=81087&id=81871
BRANCH
master
REVISION
davidedmundson marked an inline comment as done.
davidedmundson added inline comments.
INLINE COMMENTS
> mart wrote in ksysguarddaemon.cpp:58
> needs to be always polling every half a second? could it be somewhat
> adjustable (maybe depending on ac/on battery?)
Indeed, the current code is every
davidedmundson updated this revision to Diff 81087.
davidedmundson marked 23 inline comments as done.
davidedmundson added a comment.
all the changes
REPOSITORY
R106 KSysguard
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28333?vs=78977&id=81087
BRANCH
master
REVISION DETAIL
ahiemstra added inline comments.
INLINE COMMENTS
> client.cpp:45
> +{
> +for (auto sensor : m_subscribedSensors) {
> +sensor->unsubscribe();
This should probably use `qAsConst`.
> ksysguarddaemon.cpp:76
> +auto factory = qobject_cast(plugin);
> +if (!factory) {
> +
ivan added inline comments.
INLINE COMMENTS
> client.cpp:65-66
> +m_connections.insertMulti(sensor, connect(sensor,
> &SensorProperty::sensorInfoChanged, this, [this, sensor]() {
> +auto newInfo = sensor->info();
> +m_pendingMetaDataChanges[sensor->pat
ivan added inline comments.
INLINE COMMENTS
> main.cpp:45
> +m_property1->setMin(0);
> +m_property1->setMin(100);
> +m_property1->setShortName("Some Sensor 1");
`setMax`?
> client.cpp:38
> +{
> +connect(m_daemon, &KSysGuardDaemon::sensorRemoved, this, [=](const
> QS
mart added inline comments.
INLINE COMMENTS
> ksysguard_iface.xml:23
> +
> +
> +
since this is array in/array out, could consistence of naming be improved?
either
sensorsIds/sensorsInfos
or
sensorIds/sensorInfos
> ksysguarddaemon.cpp:58
> +auto timer = new QTimer(this);
> +
davidedmundson updated this revision to Diff 78977.
davidedmundson added a comment.
Register bus name after loading plugins
REPOSITORY
R106 KSysguard
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28333?vs=78658&id=78977
BRANCH
master
REVISION DETAIL
https://phabricator.kde.
davidedmundson updated this revision to Diff 78658.
davidedmundson added a comment.
Drop object library, it was too cool for some cmake versions
REPOSITORY
R106 KSysguard
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28333?vs=78625&id=78658
BRANCH
master
REVISION DETAIL
htt
zzag added inline comments.
INLINE COMMENTS
> nvidia.cpp:2-3
> +/*
> +Copyright (c) 2019 David Edmundson
> +Copyright (c) 2020 David Edmundson
> +
Typo?
REPOSITORY
R106 KSysguard
REVISION DETAIL
https://phabricator.kde.org/D28333
To: davidedmundson, #plasma
Cc: zzag, plasma-deve
davidedmundson added inline comments.
INLINE COMMENTS
> nvidiaplugin.json:1
> +{
> +"KPlugin": {
To address this, I don't use the json at all, as it's itself a factory class
which provides metadata.
But I couldnt' get rid of it without error.
REPOSITORY
R106 KSysguard
REVISION DETAIL
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
ksysguardd, whilst good, has a few problems
The code is a bit archaic, i
14 matches
Mail list logo
