davidedmundson added inline comments.
INLINE COMMENTS
> hchain wrote in plasma-core@.target:3
> can we make this `plasma-kwin@%i.service` ?
can do, the _ is just to match the binary name
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D28305
To: davidedmundson
hchain added inline comments.
INLINE COMMENTS
> plasma-core@.target:3
> +Description=KDE Plasma Workspace Core
> +Wants=plasma-plasmashell.service plasma-kwin_%i.service
> plasma-kcminit.service plasma-kded.service plasma-kcminit-phase1.service
> +Requires=plasma-ksmserver.service
can we make t
davidedmundson updated this revision to Diff 80412.
davidedmundson added a comment.
support x11 and wayland ...ish
we now call target plasma-workspace@x11 or plasma-workspace@wayland it then
can call the right services
but kwin_wayland is still currently spawned before the systemd stu
davidedmundson updated this revision to Diff 79106.
davidedmundson added a comment.
Add xembedsniproxy and gdbusmenuproxy
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28305?vs=78922&id=79106
BRANCH
master
REVISION DETAIL
https://phabricator
davidedmundson updated this revision to Diff 78922.
davidedmundson added a comment.
update
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28305?vs=78917&id=78922
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28305
AFFECTED FILES
davidedmundson updated this revision to Diff 78917.
davidedmundson added a comment.
update
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28305?vs=78541&id=78917
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28305
AFFECTED FILES
hchain added inline comments.
INLINE COMMENTS
> startplasma.cpp:404
> +startPlasmaSession.start(QStringLiteral(CMAKE_INSTALL_FULL_BINDIR
> "/plasma_session"), plasmaSessionOptions);
> +rc = startPlasmaSession.waitForStarted();
> +#else
unrelated change ?
REPOSITORY
R120 Plasma Worksp
hchain added inline comments.
INLINE COMMENTS
> hchain wrote in plasmawayland-dev.desktop.cmake:2
> does that still work in legacy (non-systemd) mode ?
original patch https://phabricator.kde.org/D19004
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D28305
To:
hchain added inline comments.
INLINE COMMENTS
> apol wrote in plasmawayland-dev.desktop.cmake:2
> Is this change related?
does that still work in legacy (non-systemd) mode ?
> apol wrote in org.kde.plasmashell.desktop.cmake:55
> We probably want it always hidden?
maybe add a comment that this
davidedmundson added inline comments.
INLINE COMMENTS
> ahiemstra wrote in CMakeLists.txt:44
> This pattern is repeated multiple times, maybe we should make a macro out of
> it? Like `install_systemd_service_file(source_file)`
that's a good idea
> apol wrote in ksmserver.service.cmake:8
> Why
apol added a comment.
Change looks good to me overall +1
INLINE COMMENTS
> ksmserver.service.cmake:8
> +# This magic minus sign means don't fail if exit code is non-zero...
> +ExecStartPost=-@QtBinariesDir@/qdbus org.kde.KSplash /KSplash
> org.kde.KSplash.setStage ksmserver
> +BusName=org.kd
ahiemstra added inline comments.
INLINE COMMENTS
> CMakeLists.txt:44
>
> +configure_file(krunner.service.cmake
> ${CMAKE_CURRENT_BINARY_DIR}/krunner.service @ONLY)
> +install( FILES ${CMAKE_CURRENT_BINARY_DIR}/krunner.service DESTINATION
This pattern is repeated multiple times, maybe we shou
davidedmundson added a comment.
In terms of testing, you will need:
- this patch
- to rerun ./login-sessions/install-sessions.sh
- cherry-picked the relevant repos in kded, kwin, kactivitymanagerd
This will give you a basic session, for everything , you'll also want
optional
davidedmundson updated this revision to Diff 78541.
davidedmundson added a comment.
add comments explaining some code
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28305?vs=78539&id=78541
BRANCH
master
REVISION DETAIL
https://phabricator.kde
davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
This brings numerous advantages such as:
- easier admin configuration with drop-ins, overrides a
nd multiple
15 matches
Mail list logo
