apol added a comment.
Change looks good to me overall +1 INLINE COMMENTS > ksmserver.service.cmake:8 > +# This magic minus sign means don't fail if exit code is non-zero... > +ExecStartPost=-@QtBinariesDir@/qdbus org.kde.KSplash /KSplash > org.kde.KSplash.setStage ksmserver > +BusName=org.kde.ksmserver Why is there a - here after the =? > plasmawayland-dev.desktop.cmake:2 > [Desktop Entry] > -Exec=dbus-run-session @CMAKE_INSTALL_FULL_LIBEXECDIR@/startplasma-dev.sh > -wayland > +Exec=@CMAKE_INSTALL_FULL_LIBEXECDIR@/startplasma-dev.sh -wayland > DesktopNames=KDE Is this change related? > org.kde.plasmashell.desktop.cmake:55 > X-KDE-StartupNotify=false > +X-KDE-HiddenUnderSystemd=true > X-DBUS-ServiceName=org.kde.plasmashell We probably want it always hidden? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28305 To: davidedmundson Cc: apol, ahiemstra, benjaminberg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
