zzag added inline comments.
INLINE COMMENTS
> ahiemstra wrote in screencaststream.cpp:549-563
> The entire framebuffer is superfluous, it is never used. glGetTexImage()
> reads from the currently bound texture, which in this case is "texture" since
> you bind it at line 546.
The fbo is gone 8a
ahiemstra added inline comments.
INLINE COMMENTS
> zzag wrote in screencaststream.cpp:549-563
> Do we actually need an fbo?
The entire framebuffer is superfluous, it is never used. glGetTexImage() reads
from the currently bound texture, which in this case is "texture" since you
bind it at line
This revision was automatically updated to reflect the committed changes.
Closed by commit R838:f6e559702cf5: Avoid copying buffer twice (authored by
jgrulich).
REPOSITORY
R838 Flatpak Support: KDE Portal for XDG Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28272?vs=78437&i
meven added a comment.
Seems good to me
REPOSITORY
R838 Flatpak Support: KDE Portal for XDG Desktop
REVISION DETAIL
https://phabricator.kde.org/D28272
To: jgrulich, #plasma
Cc: meven, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, GB_2, r
zzag added inline comments.
INLINE COMMENTS
> screencaststream.cpp:549-563
> +// bind framebuffer to copy pixels from
> +GLuint framebuffer;
> +glGenFramebuffers(1, &framebuffer);
> +glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
> +glFramebufferTexture2D(GL_FRAMEBUFFER, GL_C
jgrulich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jgrulich requested review of this revision.
REVISION SUMMARY
Previously we copied frames first to a temporary QImage and then to PipeWire
buffer. This shouldn't be
necessary as we can copy
