zzag added inline comments.

INLINE COMMENTS

> screencaststream.cpp:549-563
> +    // bind framebuffer to copy pixels from
> +    GLuint framebuffer;
> +    glGenFramebuffers(1, &framebuffer);
> +    glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
> +    glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, 
> GL_TEXTURE_2D, texture, 0);
> +    const GLenum status = glCheckFramebufferStatus(GL_FRAMEBUFFER);
> +    if (status != GL_FRAMEBUFFER_COMPLETE) {

Do we actually need an fbo?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28272

To: jgrulich, #plasma
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to